esn't implement scanforinsert
(thinking of external AMs?). I imagine this is something that I should fix, yes?
Besides that I think it's ready for review.
--
Regards, James William Pye
Index: src/backend/access/index/genam.c
==
On Sun, Feb 19, 2006 at 09:04:09PM -0500, Tom Lane wrote:
> James William Pye <[EMAIL PROTECTED]> writes:
> > Small patch that makes ScanDirection a char(f|b|n) instead of a int or
> > long or whatever enum makes it.
>
> Why is this a good idea?
A more appropriately
for sure tho as I didn't try.
>Why do we care about saving 3 bytes for ScanDirection?
It's a drop in the bucket--or maybe water vapor in the vacinity, so I doubt I
could find a stunning reason.
--
Regards, James William Pye
---(end of broadcast)---
On Sun, Feb 19, 2006 at 08:02:09PM -0500, Neil Conway wrote:
> Why?
*Very* minor. one byte instead of four.
Yes, not really worth the time, but I was poking around at code anyways and
decided to write up a little patch.
--
Regards, James William Pye
---(end of broadc
Small patch that makes ScanDirection a char(f|b|n) instead of a int or long or
whatever enum makes it. I tried to track down all the areas that depend on it
being specifically -1, 0, or 1. heapam appeared to be the biggest/only one.
(At least `gmake check` passed.)
--
Regards, James William Pye
On Thu, 2004-10-28 at 18:00, Neil Conway wrote:
> I think the code is more readable this way.
FWIW, I'm +1 on the patch for the above reason.
--
Regards,
James William Pye
signature.asc
Description: This is a digitally signed message part
.html)
Tom:
Also, what do you mean by 'break out of the '?
Have the examples follow the or have the examples set in
such a way so as the 's indentation doesn't affect the
example's text?
--
Regards,
James William Pye
signature.asc
Description: This is a digitally signed message part
was only with the lack of capitalization and ending
punctuation(as hints and details are specified to have).
--
Regards,
James William Pye
Index: aclchk.c
===
RCS file: /projects/cvsroot/pgsql-server/src/backend/catalog/ac
small hint that probably helpful in most cases..
--
Regards,
James William Pye
Index: aclchk.c
===
RCS file: /projects/cvsroot/pgsql-server/src/backend/catalog/aclchk.c,v
retrieving revision 1.104
diff -u -r1.104 aclchk.c
