Re: [PATCHES] TCL fix in HEAD

2007-10-01 Thread Marshall, Steve
Bruce Momjian wrote: Marshall, Steve wrote: The recent TCL patch assumed Tcl_NotifierProcs.initNotifierProc was added in TCL 8.2: In fact it was added in 8.4 so I have modified the CVS with the following patch. I confirmed this against the 8.2.5 release. Sorry I did not notice

Re: [PATCHES] TCL fix in HEAD

2007-10-01 Thread Marshall, Steve
I'm fine with Tom's wording and placement. This seems a bit wordy, as well as wrongly placed --- the time to tell people they need a non-multithreaded Tcl is in the installation instructions. I added the following instead. regards, tom lane

Re: [PATCHES] TCL fix in HEAD

2007-09-28 Thread Marshall, Steve
The recent TCL patch assumed Tcl_NotifierProcs.initNotifierProc was added in TCL 8.2: In fact it was added in 8.4 so I have modified the CVS with the following patch. I confirmed this against the 8.2.5 release. Sorry I did not notice that when I initially created the patch. While the patch

Re: [PATCHES] PL/TCL Patch to prevent postgres from becoming multithreaded

2007-09-21 Thread Marshall, Steve
: Thursday, September 20, 2007 8:33 PM To: Marshall, Steve Cc: pgsql-patches@postgresql.org Subject: Re: [PATCHES] PL/TCL Patch to prevent postgres from becoming multithreaded Marshall, Steve [EMAIL PROTECTED] writes: There is a problem in PL/TCL that can cause the postgres backend to become

[PATCHES] PL/TCL Patch to prevent postgres from becoming multithreaded

2007-09-11 Thread Marshall, Steve
There is a problem in PL/TCL that can cause the postgres backend to become multithreaded. Postgres is not designed to be multithreaded, so this causes downstream errors in signal handling. We have seen this cause a number of unexpected state errors associated with notification handling;