Alvaro Herrera wrote:
I wrote an "install" program in C. It's supposed to replace the
config/install-sh script, limited to the functionality we need, i.e.
what is in Makefiles in the Pg main source tree. The main objective of
this exercise is to reduce "make install" execution time; a part of tha
Mark Kirkwood wrote:
does not worry too much about a consistent view of the buffer
contents (as I didn't want it to block all other activity!).
I don't like accessing shared data structures without acquiring the
appropriate locks; even if it doesn't break anything, it seems like just
asking for t
Neil Conway wrote:
Barring any objections, I'll apply this patch to HEAD tomorrow:
http://candle.pha.pa.us/mhonarc/patches2/msg7.html
Applied.
-Neil
---(end of broadcast)---
TIP 9: the planner will ignore your desire to choose an index
Peter Eisentraut wrote:
That email message is about a timestamp data type.
Hmm, it seems that when Bruce removes items from the patch queue, the
remaining items are renumbered. You can find the original thread here:
http://archives.postgresql.org/pgsql-patches/2004-10/msg00140.php
I believe I w
Peter Eisentraut wrote:
- Casting back and forth does not preserve information. (This may be
true for some other type pairs as well, but in this case it's true in
almost every instance.)
Right, there are many other explicit casts that lose information. In
fact, I think that's somewhat the point
Barring any objections, I'll apply this patch to HEAD tomorrow:
http://candle.pha.pa.us/mhonarc/patches2/msg7.html
(Sorry, lost track of this patch as well... :P)
-Neil
---(end of broadcast)---
TIP 8: explain analyze is your friend
I've applied a modified version of this patch from seanc:
http://candle.pha.pa.us/mhonarc/patches2/msg00029.html
(Sorry, I've lost the original thread.) The patch as I applied it is
attached. Catalog version bumped.
-Neil
Index: src/backend/utils/adt/int.c
John Hansen wrote:
Will this be backpatched to 8.0?
Since it's just a performance optimization, I wasn't planning to
backpatch it, no. I suppose the OOM fix might be worth backporting,
although that is more of a theoretical problem than something I would
expect to actually occur in practice.
-N
Neil Conway wrote:
This patch optimizes the md5_text() function (which is used to implement
the md5() SQL-level function).
Applied.
-Neil
---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
subscribe
This patch optimizes the md5_text() function (which is used to implement
the md5() SQL-level function). The old code did the following:
1. de-toast the datum
2. convert it to a cstring via textout()
3. get the length of the cstring via strlen()
Since we are treating the datum context as a blob of
Neil Conway wrote:
Attached is a revised patch.
Applied to HEAD.
-Neil
---(end of broadcast)---
TIP 8: explain analyze is your friend
Tom Lane wrote:
Still a few bricks shy of a load I fear [...]
My apologies; thanks for the code review.
regression=# create or replace function foo() returns int language plpgsql as $$
regression$# begin
regression$# return ;
regression$# end$$;
CREATE FUNCTION
regression=# select foo();
server c
On Sun, 2005-02-20 at 11:18 -0700, Michael Fuhr wrote:
> The attached patch updates three books in the Bibliography to their
> most recent editions.
Patch applied to HEAD. Thanks.
-Neil
---(end of broadcast)---
TIP 8: explain analyze is your frie
On Sun, 2005-02-20 at 19:56 +0100, Magnus Hagander wrote:
> It seems the pg_ctl reference page is missing the documentation for
> register/unregister for windows services. Attached is a patch taht adds
> this (be sure to verify the markup before any commit, though!)
Applied to HEAD and REL8_0_STAB
On Thu, 2005-02-10 at 23:32 -0500, Tom Lane wrote:
> Congratulations, you just reinvented the scheme we used before 8.0.
> It's *not* an improvement. The dot-dot business is better.
Right -- but it's not very good either, and I was trying to find a
proper solution. For now I've given up and rever
On Thu, 2005-02-10 at 21:04 -0500, Tom Lane wrote:
> Maybe you should put these tests next to those then...
Ok, fair enough. Patch applied to HEAD.
-Neil
---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?
http://w
On Thu, 2005-02-10 at 20:48 -0500, Tom Lane wrote:
> You've broken the FOR syntax. You may not assume that the first token
> of a FOR-over-SELECT is literally SELECT; it could for example be a left
> parenthesis starting some kind of UNION construct.
Yeah, I was wondering if this would break anyt
On Thu, 2005-02-10 at 20:53 -0500, Tom Lane wrote:
> If you're going to add regression tests, how about testing the case of a
> non-empty-but-all-whitespace string?
AFAICS that is already tested for.
-Neil
---(end of broadcast)---
TIP 3: if posti
This patch changes the input routines for float4, float8 and oid to
reject empty strings (rather than treating them as "0"). In 8.0 we issue
a warning about this behavior and indicate that the input will not be
accepted by a future release, so it seems reasonable to disallow the
input in 8.1. The p
On Thu, 2005-02-10 at 10:15 -0500, Tom Lane wrote:
> Yeah, looks better, though I question the use of "embedded" in the
> message --- seems a bit jargony. Are you going to post a revised patch?
Actually the code to present error messages as in the previous message
was in the previous patch, just
On Thu, 2005-02-10 at 16:32 +0900, Michael Glaesemann wrote:
> I realize it's a bit late, but it might not be a bad idea to use
> CURRENT_TIMESTAMP rather than NOW(), as it's per SQL spec.
I can't say I can get very excited about it; someone is free to submit a
patch if they like.
-Neil
-
On Wed, 2005-02-09 at 23:57 -0500, Tom Lane wrote:
> That seems like a step backwards from the current behavior [...]
Hmm, fair enough. Is this better?
create function bad_sql1() returns int as $$
declare a int;
begin
a := 5;
Johnny Yuma;
a := 10;
return a;
end$$ language 'plpgsql
Applied, thanks.
On Wed, 2005-02-02 at 17:33 +1300, Mark Kirkwood wrote:
> As discussed on -docs.
> (Not really sure if I need to explicitly forward here)
Yeah, forwarding (or CC'ing) to -patches is helpful.
-Neil
---(end of broadcast)---
TI
On Thu, 2005-01-27 at 02:28 -0800, David Fetter wrote:
> This one from Ben Calvert. It uses the (imho clearer) NOW() rather
> than 'NOW' in a PL/PgSQL function example.
Applied, thanks.
-Neil
---(end of broadcast)---
TIP 3: if posting/reading th
Another version of the patch is attached. Changes:
- clean up grammar so that read_sql_construct() is always called to read
a well-formed SQL expression. That way we can check for errors in
embedded SQL by just adding a single function call to
read_sql_construct(), rather than adding calls at most
On Wed, 2005-02-09 at 18:35 -0500, Bruce Momjian wrote:
> It is still in my mailbox for review. Sorry.
Yeah, my apologies as well, I've been busy with other things. Bruce, if
you'd like to review & apply this you are welcome to. Otherwise let me
know and I'll take a look.
-Neil
---
On Wed, 2005-02-09 at 15:56 +1100, Neil Conway wrote:
> This patch changes ATRewriteTable() to switch to the per-tuple memory
> context before beginning the per-tuple loop.
[...]
> Barring any objections, I will apply this to HEAD and REL8_0_STABLE
> tomorrow.
App
ALTER TABLE ADD COLUMN exhibits a significant memory leak when adding a
column with a default expression. In that situation, we need to rewrite
the heap relation. To evaluate the new default expression, we use
ExecEvalExpr(); however, this can allocate memory in the current memory
context, and ATRe
On Tue, 2005-02-08 at 13:25 -0500, Tom Lane wrote:
> When you apply this, please put the remaining array-overflow checks
> before the overflow occurs, not after.
Actually, my original fix _does_ check for the overflow before it
occurs. ISTM both fixes are essentially identical, although yours may
On Mon, 2005-02-07 at 21:25 -0500, Tom Lane wrote:
> I haven't looked lately, but my recollection is that there are just a
> few calls into the main backend from pl_comp.c. I'm not sure they are
> all to backend/parser though; check /catalog, etc as well.
Attached is a patch that implements this.
On Mon, 2005-02-07 at 19:22 -0500, Tom Lane wrote:
> What might work is to run in the function context as the basic state,
> but switch to a short-term context when calling any main-backend code
> from pl_comp.c. I'm not sure how many such calls there are, but if it's
> not more than a dozen or tw
On Mon, 2005-02-07 at 10:41 -0500, Tom Lane wrote:
> My recollection is that I was not nearly as worried about short-term
> pallocs in the plpgsql code itself, as about leakage in various main-
> backend routines that get called incidentally during parsing.
> backend/parser/ is quite cavalier about
Heikki Linnakangas wrote:
There's two almost identical pieces of code in LockRelease and
LockReleaseAll that do the opposite of GrantLock.
Here's a small patch that replaces those pieces with a static
UnGrantLock function.
Applied to HEAD with a few trivial editorial fixes.
Thanks for the patch.
On Wed, 2005-02-02 at 21:41 +0200, Heikki Linnakangas wrote:
> There's two almost identical pieces of code in LockRelease and
> LockReleaseAll that do the opposite of GrantLock.
>
> Here's a small patch that replaces those pieces with a static UnGrantLock
> function.
LockReleaseAll() did not up
On Wed, 2005-02-02 at 00:39 -0500, Tom Lane wrote:
> isViewOnTempTable_walker. If that isn't euphonious to you, then change
> the name of isViewOnTempTable. Everywhere else that we have walker
> subroutines, foo() invokes foo_walker(). You need a seriously good reason
> to deviate from that conv
On Wed, 2005-02-02 at 00:39 -0500, Tom Lane wrote:
> Maybe I'm reading the wrong thing, but the only uses of CASCADED-with-
> a-D that I see in the spec are in the context of WITH CHECK OPTION,
> which this patch does not implement.
Precisely; prior to the patch, WITH CHECK OPTION was documented i
On Tue, 2005-02-01 at 01:28 -0500, Tom Lane wrote:
> The references to "CASCADED" (sic) in the patch are surely bogus.
Per SQL:2003 section 11.22, it is spelt "CASCADED". I'm not sure there's
a whole lot of value in documenting syntax we don't support, but if
we're going to do it we may as well ge
On Mon, 2004-09-27 at 09:39 +1000, Koju Iijima wrote:
> I have implemented temporary view related items as I proposed few days ago.
> http://archives.postgresql.org/pgsql-hackers/2004-09/msg00682.php
Barring any objections, I'll apply this patch tomorrow.
-Neil
---(end
On Wed, 2004-12-29 at 11:36 -0500, Stephen Frost wrote:
> Small patch to move get_grosysid() from catalog/aclchk.c to
> utils/cache/lsyscache.c where it can be used by other things. Also
> cleans up both get_usesysid() and get_grosysid() a bit.
Applied to HEAD. Thanks for the patch.
-Neil
On Wed, 2004-09-08 at 16:31 -0400, Alvaro Herrera wrote:
> Here is a simple patch that changes heap_modifytuple to require a
> TupleDesc instead of a Relation (driven off a comment in the same
> function).
Patch applied to HEAD. I went to the trouble of checking the call sites
of heap_modifytuple(
On Thu, 2005-01-27 at 08:05 +0100, Michael Paesold wrote:
> Perhaps you could rename indices_size to indexes_size.
Yeah, sorry -- forgot to mention that. I believe we decided to
standardize on "indexes" as the plural of "index" (at least in
user-visible stuff) a few releases go.
Good catch :)
-N
On Wed, 2004-12-29 at 11:36 -0500, Stephen Frost wrote:
> Small patch to move get_grosysid() from catalog/aclchk.c to
> utils/cache/lsyscache.c where it can be used by other things. Also
> cleans up both get_usesysid() and get_grosysid() a bit. This is in
> preparation for 'Group Ownersh
On Wed, 2005-01-12 at 17:34 +1100, Brendan Jurd wrote:
> Thanks Alvaro, changes made and new patch attached.
Applied to HEAD -- thanks for the patch.
Another style tip: we don't accept code that produces compiler warnings
(pretty much), so checking that before submitting patches would be nice.
-
On Tue, 2005-01-25 at 16:49 -0700, Ed L. wrote:
> The attached dbsize patch:
>
> + makes relation_size(relname) include toast tables;
> + adds aggregate_relation_size(relname) to count table data and indices;
> + adds indices_size(relname) to report the size of indices for a
> r
Kris Jurka wrote:
I've attached two new patches. One revising my original patch to
make the function creations consistent and the other to just fix the
problem in the existing code (which should be backported as far as people
would like to).
Full patch applied to HEAD, fix for STRICT applied to 8.
On Tue, 2005-01-25 at 02:26 -0500, Kris Jurka wrote:
> Yes, it should, and even more importantly strict because it crashes when
> called with null inputs. I copied this off the adjacent entry without
> thinking about it. So currently SELECT text_soundex(NULL); crashes the
> server.
Ah, good catc
On Tue, 2005-01-25 at 01:13 -0500, Kris Jurka wrote:
> The attached patch implements the soundex difference function which
> compares two strings' soundex values for similarity.
*** 19,24
--- 19,28
AS 'MODULE_PATHNAME', 'soundex'
LANGUAGE 'C';
+ CREATE FUNCTION difference(text,te
On Tue, 2005-01-25 at 11:56 +1100, Neil Conway wrote:
> This patch adds a regression test for the bug with domains and ALTER
> TABLE that Tom fixed a few hours ago.
Applied.
-Neil
---(end of broadcast)---
TIP 5: Have you checked our ext
On Mon, 2005-01-24 at 22:22 -0500, Tom Lane wrote:
> It might be better to make the tables TEMP tables --- there are some
> regression tests that depend on the set of existing tables, IIRC.
> Otherwise ok.
True, although those kind of dependencies usually cause an obvious test
failure (which this
This patch adds a regression test for the bug with domains and ALTER
TABLE that Tom fixed a few hours ago.
Barring any objections I'll apply this to HEAD by the end of the day.
-Neil
Index: src/test/regress/expected/domain.out
===
R
On Mon, 2005-01-24 at 18:43 -0500, Tom Lane wrote:
> Well, the thing that's bothering me is that you are undoing a number of
> changes that we'll probably just have to redo later; with consequently
> *two* chances to introduce bugs.
I'm not sure if we should apply this patch to both HEAD and
REL8_
On Mon, 2005-01-24 at 17:39 -0500, Tom Lane wrote:
> I'm more than slightly uncomfortable with the size of this patch.
[...]
> I think it would be better and safer to try to localize the changes
> into freelist.c.
IMHO that is basically what the patch does; the changes to other files
are either co
On Sat, 2005-01-22 at 21:13 +1100, Neil Conway wrote:
> Barring any objections I'll apply this patch to REL8_0_STABLE and HEAD
> on Monday.
Applied, thanks for the patch.
-Neil
---(end of broadcast)---
TIP 3: if posting/reading thr
Tom Lane wrote:
The code beginning at freelist.c line 645 is intended to deal with this.
Ah, good point -- sorry, I missed that. The code as-is should be fine, then.
-Neil
---(end of broadcast)---
TIP 2: you can get off all lists at once with the unre
Alvaro Herrera wrote:
Hmm ... I think you should rather use a PG_TRY/PG_CATCH block.
Thanks for the suggestion, Alvaro -- I think that's a better way to go.
It means we can keep vacuum-specific stuff in vacuum.c, rather than
adding to AbortTransaction(). I'll post a revised patch tomorrow.
While
It occurred to me that if we elog(ERROR) during VACUUM, the vacuum
activity hint will not be reset. This will result in all subsequent I/O
by the current backend being treated by the bufmgr as though it resulted
from VACUUM. While elog(ERROR) during VACUUM is not a common occurrence,
I don't th
Dave Page wrote:
Theis patch supercedes *all* my earlier ones from today - apologies for
the noise, clearly I need a beer or 3 and a few nights away from the
laptop.
@@ -1166,7 +1166,9 @@
exit(0);
#ifdef WIN32
case 'E':
- args->service_dependencies = optarg;
+
Neil Conway wrote:
This patch updates the regression tests to allow "make installcheck" to
pass if "default_with_oids" is set to false. I took the approach of
explicitly adding WITH OIDS to the CREATE TABLEs where necessary, rather
than tweaking the default_with_oids GUC var.
On Thu, 2005-01-20 at 07:57 -0500, Tom Lane wrote:
> Not sure, but it seems like at least as straightforward a translation
> as the other way. More to the point, it makes clear the difference
> between what is meant to be a long-lived data structure and what isn't.
The latter point is sound, I th
On Thu, 2005-01-20 at 15:48 +1100, Neil Conway wrote:
> Attached is a revised patch (no major changes, just grammar cleanup).
> While rewriting some cruft in PL/PgSQL's gram.y, I noticed that we will
> overflow a heap-allocated array if the user specifies more than 1024
> paramete
This patch updates the regression tests to allow "make installcheck" to
pass if "default_with_oids" is set to false. I took the approach of
explicitly adding WITH OIDS to the CREATE TABLEs where necessary, rather
than tweaking the default_with_oids GUC var.
Barring any objections, I intend to appl
On Wed, 2005-01-19 at 18:39 +1100, Neil Conway wrote:
> Attached is a revised patch. Barring any objections, I intend to apply
> this sometime tomorrow.
Applied.
-Neil
---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster
On Tue, 2005-01-18 at 00:54 -0500, Tom Lane wrote:
> I won't stand in the way of you doing this
Attached is a revised patch. Barring any objections, I intend to apply
this sometime tomorrow.
-Neil
Index: src/backend/parser/parse_expr.c
On Wed, 2005-01-19 at 09:55 +1100, Neil Conway wrote:
> This patch adds some minimal regression tests for refcursors in PL/PgSQL
> (if someone wants to augment these with more, go right ahead).
Applied.
-Neil
---(end of broadcast)---
TIP
On Tue, 2005-01-18 at 16:43 +1100, Neil Conway wrote:
> Barring any objections, I intend to apply this patch tomorrow.
Applied.
-Neil
---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please send an appropriate
subscr
On Sat, 2005-01-15 at 01:01 -0300, Alvaro Herrera wrote:
> This patches corrects the use of 0 as NULL in dllist.c, as reported by
> sparse. There are still other places to be corrected.
Applied -- thanks.
(Bruce, you can take this off the 8.1 patches queue.)
-Neil
---
This patch adds some minimal regression tests for refcursors in PL/PgSQL
(if someone wants to augment these with more, go right ahead). Barring
any objections, I intend to apply this to HEAD before end of day.
-Neil
Index: src/test/regress/expected/plpgsql.out
Barring any objections, I intend to apply this patch tomorrow. The
patch, as well as the original -patches email, are included below.
-Neil
On Wed, 2004-11-24 at 11:15 +1100, Neil Conway wrote:
> This patch makes some improvements to the rtree index implementation:
>
> (1) Keep a p
On Thu, 2004-10-28 at 16:49 +1000, Neil Conway wrote:
> This patch refactors transformExpr(): rather than being a monsterous 900
> line function, it breaks it up into numerous sub-functions that are
> invoked by transformExpr() for individual expression types, in the style
> of transfo
On Sun, 2005-01-16 at 22:31 -0500, Tom Lane wrote:
> I had intended to put in something like that myself, but forgot. Feel
> free to apply now.
Applied.
-Neil
---(end of broadcast)---
TIP 4: Don't 'kill -9' the postmaster
This trivial patch adds a regression test for CASE expressions that use
an untyped literal in the CASE's test expression. This adds test
coverage for a bug that was fixed by Tom on Jan. 12
I intend to apply this once 8.0.0 is out the door, barring any
objections.
-Neil
Index: src/test/regress/ex
On Mon, 2004-12-13 at 11:30 +, Dave Page wrote:
>
> > -Original Message-
> > From: Neil Conway [mailto:[EMAIL PROTECTED]
> > Sent: 13 December 2004 03:59
> > To: Dave Page
> > Cc: pgsql-patches
> > Subject: RE: [PATCHES] pg_resetxlog as ro
On Sun, 2004-12-12 at 23:59 +, Dave Page wrote:
> Sounds reasonable to me.
Attached is a patch that implements this.
src/port/backend/win32/security.c is moved to src/port/win32_security.c,
and conditionally added to LIBOBJS. Note that I don't have much
experience with the build system, and le
We should prevent pg_resetxlog from being run as root: it writes new
files to $PGDATA, so running the tool as root will result in those files
being owned by root, which makes the data directory unusable.
Attached is a trivial patch that makes this change for Unix. I suppose a
similar fix is needed
On Thu, 2004-12-02 at 00:52 +, Jon Jensen wrote:
> This is a little patch to correct the documentation on CVS. The URL for
> downloading CVS at cyclic.com site is long defunct, and I changed the text
> to not overtly recommend CVS 1.10, a now fairly old version.
Applied. Thanks!
-Neil
Neil Conway wrote:
(BTW, another thing this example exposes is that we don't issue warnings
about trivially-dead-code, such as statements in a basic block that
follow a RETURN. This would probably be also worth doing.)
Attached is a patch that implements this. Specifically, if there ar
On Tue, 2004-11-23 at 23:40 -0500, Tom Lane wrote:
> Please hold this for the 8.1 cycle. I think we are past the time for
> non-bug-fix changes in the 8.0 release.
Sorry, I should have mentioned that explicitly: I have (and had) no
intention of applying this for 8.0.
-Neil
---
On Wed, 2004-11-24 at 11:18 +1100, Neil Conway wrote:
> This patch makes a trivial improvement to IncrBufferRefCount(): rather
> than asserting that BufferIsValid() and then manually asserting its pin
> count is > 0, we can just assert BufferIsPinned().
App
This patch makes a trivial improvement to IncrBufferRefCount(): rather
than asserting that BufferIsValid() and then manually asserting its pin
count is > 0, we can just assert BufferIsPinned().
I'll apply to HEAD before end of day, barring any objections.
-Neil
--- src/backend/storage/buffer/buf
This patch makes some improvements to the rtree index implementation:
(1) Keep a pin on the scan's current buffer and mark buffer. This avoids
the need to do a ReadBuffer() for each tuple produced by the scan.
(2) Convert a ReleaseBuffer() ; ReadBuffer() pair into
ReleaseAndReadBuffer(). Surely n
On Tue, 2004-11-23 at 11:24 +1100, Neil Conway wrote:
> Attached is a revised patch. Will apply in a few hours barring any
> objections.
Applied.
-Neil
---(end of broadcast)---
TIP 8: explain analyze is your friend
On Mon, 2004-11-22 at 19:10 -0500, Tom Lane wrote:
> Please do; I dislike makefiles that won't "make clean" ...
Attached is a revised patch. Will apply in a few hours barring any
objections.
-Neil
#
# patch "contrib/pgcrypto/random.c"
# from [2815b119334369b864e6b39fe21832b299fd235c]
#to [
Perhaps I wasn't clear: the *present* behavior of pgcrypto is to
"compile successfully but ... be unusable" if an invalid random source
is defined. This is prone to error. That patch changes this behavior to
refuse to compile if an invalid random source has been defined.
On Mon, 2004-11-22 at 10:4
On Sun, 2004-11-21 at 22:49 -0700, Michael Fuhr wrote:
> The 8.0.0beta5 Release Notes contain a reference to g_restore instead
> of pg_restore.
Applied. Thanks!
-Neil
---(end of broadcast)---
TIP 5: Have you checked our extensive FAQ?
This patch makes the pgcrypto Makefile check that a recognized random
source has been defined. If no such source is defined, pgcrypto will
compile successfully but will be unusable.
(An alternative place to do the check would be in random.c; comments on
which location is preferrable are welcome.)
On Sun, 2004-11-07 at 17:50 -0500, Andrew Dunstan wrote:
> The attached patch adds a few prototypes and does a typecast, thus
> removing some harmless but annoying compile warnings on Win32.
Applied.
-Neil
---(end of broadcast)---
TIP 8: explain
On Wed, 2004-11-17 at 11:20 +1100, Neil Conway wrote:
> This patch makes a minor optimization to the restrpos() and markpos()
> implementations for btree and hash: to bump the reference count on a
> buffer, it is more efficient to use IncrBufferRefCount() than to do a
> ReadBuffer
App
On Tue, 2004-11-16 at 19:46 -0500, Andrew Dunstan wrote:
> That attached patch updates the docs for COPY CSV to include the
> recently discussed limitation on importing data with embedded line-end
> characters.
Applied, with changes: I thought was overkill, and IMHO the
wording of the addition
On Sun, 2004-11-14 at 23:05 +1100, Gavin Sherry wrote:
> Attached is a patch which checks early on in pg_start_back() that
> archive_command is defined and if not generates an error.
Applied, with some tweaks.
Thanks.
-Neil
---(end of broadcast)
This patch makes a minor optimization to the restrpos() and markpos()
implementations for btree and hash: to bump the reference count on a
buffer, it is more efficient to use IncrBufferRefCount() than to do a
ReadBuffer (for one thing we needn't acquire the BufMgrLock; we also
don't need to do a ha
On Sun, 2004-11-14 at 23:05 +1100, Gavin Sherry wrote:
> Attached is a patch which checks early on in pg_start_back() that
> archive_command is defined and if not generates an error. This seemed like
> a reason foot gun prevention measure.
I'll apply this before end of day today.
-Neil
---
On Mon, 2004-11-15 at 17:16 +1100, Neil Conway wrote:
> This patch adds index entries for each GUC parameter. Previously, only a
> handful of GUC parameters has index entries.
Applied.
-Neil
---(end of broadcast)---
TIP 5: Have you check
On Mon, 2004-11-15 at 11:27 +1100, Neil Conway wrote:
> This patch replaces "---" with "—" in the documentation, which is
> the proper SGML character entity for an emdash.
Patch applied. I also fixed up cases where "--" was used in a similar
fashion ("--&q
On Mon, 2004-11-15 at 01:35 -0300, Alvaro Herrera wrote:
> Is ". ---" really correct? I think there should be no period there.
Good catch -- I'll rephrase that text.
-Neil
---(end of broadcast)---
TIP 3: if posting/reading through Usenet, please
This patch replaces "---" with "—" in the documentation, which is
the proper SGML character entity for an emdash.
Barring any objections, I'll apply this to HEAD before the end of the
day.
-Neil
# Old manifest: 01f0baf61d31b0bbe7563ce51fd262481b20ca57
# New manifest: fcb6532423fefa04824a2aefd07c
Simon Riggs wrote:
I note at least 3 people have submitted patches in other
formats in the last week.
I'm one of the guilty parties (as is Gavin, I'd imagine). As I explained
in an earlier mail to -patches, the reason I've been submitting unified
diffs is that Gavin and I have been using the Mono
Gavin Sherry wrote:
Just some docs enhancements based on feedback I received from a few recent
talks on PITR.
Applied, with a bunch of additional fixes.
-Neil
---(end of broadcast)---
TIP 8: explain analyze is your friend
Tom Lane wrote:
Agreed. I get the impression that at one time it was not so, but
certainly for the last many years there's been no need to test.
Patch applied.
A related issue in the same general area is that the smgr code is
currently implemented to elog on error, but its API still reflects
an as
Gavin Sherry wrote:
Just some docs enhancements based on feedback I received from a few recent
talks on PITR.
I'll apply this to HEAD tonight or tomorrow.
-Neil
---(end of broadcast)---
TIP 8: explain analyze is your friend
AFAIK, ReadBuffer() will elog on error, so callers can assume that the
buffer it returns is valid. The vast majority of ReadBuffer() call sites
make this assumption, but some went to the trouble of checking that the
returned buffer was valid and elog'ing if it was not. I've removed the
error ch
601 - 700 of 1000 matches
Mail list logo
