[Fwd: Re: [HACKERS] [PATCHES] plperl and pltcl installcheck targets]

[Andrew Dunstan]

I don't know what heppened to the original of this. Maybe it caught by 
some filter because of the .tgz file. So instead of including it again I 
have uploaded it to planetpostgresql. It can be got here: 
|http://people.planetpostgresql.org/andrew/wp-content/plregress.tgz

cheers
andrew
|
-----------------------
Tom Lane wrote:
Andrew Dunstan <[EMAIL PROTECTED]> writes:
 

Is that what you had in mind?
   

Not entirely.  We should move around the test sql script and the expected
result file so that the file structure looks exactly like one of the
test-enabled contrib modules.  I realize that's a PITA to describe as a
patch --- just tell me in words what to put where (ls -lR maybe) and
it shall be so.
 

OK, here's what I have. The tgz file contains the sql and expected 
directories for the 3 PLs, plus there's a patch for the makefiles. With 
this the following would become redundant:

pl/plperl/test/*
pl/tcl/test/*
pl/plpython/*.sql
pl/plpython/{feature,error}.*
pl/plpython/test.sh
If you wanted to you could preserve history by moving and renaming the 
sql files - I'm not sure it're really worth it.

cheers
andrew

Index: plperl/GNUmakefile
===================================================================
RCS file: /home/cvsmirror/pgsql/src/pl/plperl/GNUmakefile,v
retrieving revision 1.18
diff -c -r1.18 GNUmakefile
*** plperl/GNUmakefile  19 Nov 2004 19:22:58 -0000      1.18
--- plperl/GNUmakefile  13 May 2005 01:03:13 -0000
***************
*** 53,58 ****
--- 53,63 ----
         echo "*****"
  endif
  
+ TESTS = plperl
+ installcheck:
+       $(top_srcdir)/src/test/regress/pg_regress --load-language=plperl 
$(TESTS)
+ 
+ 
  installdirs:
        $(mkinstalldirs) $(DESTDIR)$(pkglibdir)
  
Index: plpython/Makefile
===================================================================
RCS file: /home/cvsmirror/pgsql/src/pl/plpython/Makefile,v
retrieving revision 1.18
diff -c -r1.18 Makefile
*** plpython/Makefile   19 Nov 2004 19:23:01 -0000      1.18
--- plpython/Makefile   12 May 2005 15:18:03 -0000
***************
*** 85,92 ****
        rm -f python${pytverstr}.def
  endif
  
  installcheck:
!       PATH=$(bindir):$$PATH $(SHELL) $(srcdir)/test.sh
  
  else # can't build
  
--- 85,94 ----
        rm -f python${pytverstr}.def
  endif
  
+ TESTS = plpython_schema plpython_populate plpython_function plpython_test 
plpython_error
  installcheck:
!       $(top_srcdir)/src/test/regress/pg_regress --load-language=plpythonu 
$(TESTS)
! 
  
  else # can't build
  
Index: tcl/Makefile
===================================================================
RCS file: /home/cvsmirror/pgsql/src/pl/tcl/Makefile,v
retrieving revision 1.44
diff -c -r1.44 Makefile
*** tcl/Makefile        16 Dec 2004 20:41:01 -0000      1.44
--- tcl/Makefile        12 May 2005 16:46:58 -0000
***************
*** 57,62 ****
--- 57,68 ----
  endif
        $(MAKE) -C modules $@
  
+ TESTS = pltcl_setup pltcl_queries
+ installcheck:
+       $(top_srcdir)/src/test/regress/pg_regress --load-language=pltcl $(TESTS)
+ 
+ 
+ 
  installdirs:
        $(mkinstalldirs) $(DESTDIR)$(pkglibdir)
        $(MAKE) -C modules $@
---------------------------(end of broadcast)---------------------------
TIP 7: don't forget to increase your free space map settings