Re: [HACKERS] [PATCHES] extension for sql update

2006-09-05 Thread Susanne Ebrecht
Bruce Momjian wrote: Susanne Ebrecht wrote: Is it too hard to rip it back out once the full row support arrives? That seems speculation at best anyway. That's what I was thinking. Glad someone else replied. ;-) If you're looking for

Re: [HACKERS] [PATCHES] extension for sql update

2006-09-02 Thread Bruce Momjian
bruce wrote: > I have merged your patch into current CVS and applied it; attached. > There was quite a bit of code drift. One drift area was the new > RETURNING clause; that was easy to fix. A more complex case is the > code no longer has values as ResTargets --- it is a simple a_expr list, > s

Re: [HACKERS] [PATCHES] extension for sql update

2006-09-02 Thread Bruce Momjian
Susanne Ebrecht wrote: > >> Is it too hard to rip it back out once the full row support > >> arrives? That seems speculation at best anyway. > >> > > That's what I was thinking. Glad someone else replied. ;-) > > > If you're looking for votes, +1.

Re: [HACKERS] [PATCHES] extension for sql update

2006-07-31 Thread Jim C. Nasby
On Sun, Jul 30, 2006 at 08:38:30PM -0400, Rod Taylor wrote: > On Sun, 2006-07-30 at 20:20 -0400, Robert Treat wrote: > > On Thursday 27 July 2006 09:28, Bruce Momjian wrote: > > > Tom Lane wrote: > > > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > > > Tom Lane wrote: > > > > >> UPDATE mytab SET

Re: [HACKERS] [PATCHES] extension for sql update

2006-07-30 Thread Rod Taylor
On Sun, 2006-07-30 at 20:20 -0400, Robert Treat wrote: > On Thursday 27 July 2006 09:28, Bruce Momjian wrote: > > Tom Lane wrote: > > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > > Tom Lane wrote: > > > >> UPDATE mytab SET (foo, bar, baz) = > > > >> (SELECT alpha, beta, gamma FROM othertab WHE

Re: [HACKERS] [PATCHES] extension for sql update

2006-07-30 Thread Robert Treat
On Thursday 27 July 2006 09:28, Bruce Momjian wrote: > Tom Lane wrote: > > Bruce Momjian <[EMAIL PROTECTED]> writes: > > > Tom Lane wrote: > > >> UPDATE mytab SET (foo, bar, baz) = > > >> (SELECT alpha, beta, gamma FROM othertab WHERE key = mytab.key); > > > > > > That UPDATE example is interesting

Re: [HACKERS] [PATCHES] extension for sql update

2006-07-27 Thread Bruce Momjian
Jim Nasby wrote: > On Jul 27, 2006, at 7:30 AM, Tom Lane wrote: > > Susanne Ebrecht <[EMAIL PROTECTED]> writes: > >> ... We could provide the mixed update syntax and leave the > >> typed row value expression for the next release. Do you agree? > > > > I don't really see the point --- the patch won'

Re: [HACKERS] [PATCHES] extension for sql update

2006-07-27 Thread Florian G. Pflug
Tom Lane wrote: Susanne Ebrecht <[EMAIL PROTECTED]> writes: ... We could provide the mixed update syntax and leave the typed row value expression for the next release. Do you agree? I don't really see the point --- the patch won't provide any new functionality in anything like its current form

Re: [HACKERS] [PATCHES] extension for sql update

2006-07-27 Thread Jim Nasby
On Jul 27, 2006, at 7:30 AM, Tom Lane wrote: Susanne Ebrecht <[EMAIL PROTECTED]> writes: ... We could provide the mixed update syntax and leave the typed row value expression for the next release. Do you agree? I don't really see the point --- the patch won't provide any new functionality in a