[PATCHES] "ALSO" keyword to "CREATE RULE" patch

2004-06-09 Thread Fabien COELHO
Dear patchers, Please find attached a small patch to add an optionnal "ALSO" keyword to the "CREATE RULE" syntax. The "ALSO" keyword can be used where "INSTEAD" would be used, to mean the opposite, i.e. the current default behavior of rules which adds operations to the current one. IMHO, it make

Re: [PATCHES] "ALSO" keyword to "CREATE RULE" patch

2004-03-09 Thread Fabien COELHO
> I thought the syntax came from Berkeley. We can add ALSO if folks like > it. I can't think of cases where we have keywords for both on and off > behavior, and allow a default if the keyword is missing. ALTER TABLE ... DROP CONSTRAINT ... [ RESTRICT | CASCADE ] CREATE TABLE ... [ WITH OIDS |

Re: [PATCHES] "ALSO" keyword to "CREATE RULE" patch

2004-03-08 Thread Bruce Momjian
Patch applied. Thanks. --- Fabien COELHO wrote: > > > Shoot me the patch again and I will put in the the queue. Thanks. > > Please find attached (again) the patch I sent. It is against 7.4.1. > If necessary, I can redo

Re: [PATCHES] "ALSO" keyword to "CREATE RULE" patch

2004-03-04 Thread Bruce Momjian
Jan Wieck wrote: > Bruce Momjian wrote: > > > Jan Wieck wrote: > >> Tom Lane wrote: > >> > >> > Fabien COELHO <[EMAIL PROTECTED]> writes: > >> >> Most of the patch deals with the documentation, which is rather ugly > >> >> because it keeps telling about "INSTEAD" vs "non-INSTEAD" rules, as there

Re: [PATCHES] "ALSO" keyword to "CREATE RULE" patch

2004-03-04 Thread Jan Wieck
Bruce Momjian wrote: Jan Wieck wrote: Tom Lane wrote: > Fabien COELHO <[EMAIL PROTECTED]> writes: >> Most of the patch deals with the documentation, which is rather ugly >> because it keeps telling about "INSTEAD" vs "non-INSTEAD" rules, as there >> is no name for the default behavior. I think "A

Re: [PATCHES] "ALSO" keyword to "CREATE RULE" patch

2004-03-04 Thread Bruce Momjian
Jan Wieck wrote: > Tom Lane wrote: > > > Fabien COELHO <[EMAIL PROTECTED]> writes: > >> Most of the patch deals with the documentation, which is rather ugly > >> because it keeps telling about "INSTEAD" vs "non-INSTEAD" rules, as there > >> is no name for the default behavior. I think "ALSO" fixes

Re: [PATCHES] "ALSO" keyword to "CREATE RULE" patch

2004-03-04 Thread Jan Wieck
Tom Lane wrote: Fabien COELHO <[EMAIL PROTECTED]> writes: Most of the patch deals with the documentation, which is rather ugly because it keeps telling about "INSTEAD" vs "non-INSTEAD" rules, as there is no name for the default behavior. I think "ALSO" fixes this issue as it clarifies the explanat

Re: [PATCHES] "ALSO" keyword to "CREATE RULE" patch

2004-03-04 Thread Fabien COELHO
> Shoot me the patch again and I will put in the the queue. Thanks. Please find attached (again) the patch I sent. It is against 7.4.1. If necessary, I can redo the job against current head. Have a nice day, -- Fabien Coelho - [EMAIL PROTECTED]*** ./doc/src/sgml/rules.sgml.orig Sun Feb 2

Re: [PATCHES] "ALSO" keyword to "CREATE RULE" patch

2004-03-04 Thread Bruce Momjian
Fabien COELHO wrote: > > > I thought the syntax came from Berkeley. We can add ALSO if folks like > > it. I can't think of cases where we have keywords for both on and off > > behavior, and allow a default if the keyword is missing. > > ALTER TABLE ... DROP CONSTRAINT ... [ RESTRICT | CASCADE ]

Re: [PATCHES] "ALSO" keyword to "CREATE RULE" patch

2004-03-04 Thread Fabien COELHO
> I thought the syntax came from Berkeley. We can add ALSO if folks like > it. I can't think of cases where we have keywords for both on and off > behavior, and allow a default if the keyword is missing. ALTER TABLE ... DROP CONSTRAINT ... [ RESTRICT | CASCADE ] ; CREATE TABLE ... [ WITH OIDS

Re: [PATCHES] "ALSO" keyword to "CREATE RULE" patch

2004-03-04 Thread Bruce Momjian
Tom Lane wrote: > Fabien COELHO <[EMAIL PROTECTED]> writes: > > Most of the patch deals with the documentation, which is rather ugly > > because it keeps telling about "INSTEAD" vs "non-INSTEAD" rules, as there > > is no name for the default behavior. I think "ALSO" fixes this issue as it > > clari

Re: [PATCHES] "ALSO" keyword to "CREATE RULE" patch

2004-03-04 Thread Tom Lane
Fabien COELHO <[EMAIL PROTECTED]> writes: > Most of the patch deals with the documentation, which is rather ugly > because it keeps telling about "INSTEAD" vs "non-INSTEAD" rules, as there > is no name for the default behavior. I think "ALSO" fixes this issue as it > clarifies the explanations. Hm

Re: [PATCHES] "ALSO" keyword to "CREATE RULE" patch

2004-03-04 Thread Fabien COELHO
Dear Bruce, > Is ALSO part of the SQL standard? I can't imagine it is because there > is no rule mention. As RULE is not in the SQL standard, ALSO is sure no part of it. > I guess if we were coding from scratch, we could make the syntax INSTEAD > or ALSO, but at this point, I don't see adding

Re: [PATCHES] "ALSO" keyword to "CREATE RULE" patch

2004-03-03 Thread Bruce Momjian
Is ALSO part of the SQL standard? I can't imagine it is because there is no rule mention. I guess if were were coding from scratch, we could make the syntax INSTEAD or ALSO, but at this point, I don't see adding ALSO as a useful change.