Re: [PATCHES] (repost) pgtcl: restore 8.0 compatibility for large obj fix

2003-11-06 Thread Tom Lane
ljb <[EMAIL PROTECTED]> writes: > Meaning: Tcl 8.0 added "binary strings", and handled binary data in String > objects. Tcl 8.1 internationalized those strings to make them store UTF-8, > and introduced ByteArray objects to hold binary data. So the original code > should work fine in Tcl 8.0, and

Re: [PATCHES] (repost) pgtcl: restore 8.0 compatibility for large obj fix

2003-11-06 Thread ljb
[EMAIL PROTECTED] wrote: > ljb <[EMAIL PROTECTED]> writes: >> +#if TCL_MAJOR_VERSION == 8 && TCL_MINOR_VERSION >= 1 || TCL_MAJOR_VERSION > 8 >> +bufObj = Tcl_NewByteArrayObj(buf, nbytes); >> +#else >> bufObj = Tcl_NewStringObj(buf, nbytes); >> +#endif > > Hmm. We could certainly do it lik

Re: [PATCHES] (repost) pgtcl: restore 8.0 compatibility for large obj fix

2003-11-05 Thread Tom Lane
ljb <[EMAIL PROTECTED]> writes: > +#if TCL_MAJOR_VERSION == 8 && TCL_MINOR_VERSION >= 1 || TCL_MAJOR_VERSION > 8 > + bufObj = Tcl_NewByteArrayObj(buf, nbytes); > +#else > bufObj = Tcl_NewStringObj(buf, nbytes); > +#endif Hmm. We could certainly do it like that, but does this actually fi

[PATCHES] (repost) pgtcl: restore 8.0 compatibility for large obj fix

2003-11-05 Thread ljb
This is a repost of my 29 Oct 2003 message, which didn't seem to make it all the way in. It restores Tcl 8.0 compatibility, which was lost in my patch to fix corrupt binary data transfer in pg_lo_read and pg_lo_write. Sorry, this is against PostgreSQL-7.4beta5 which was the latest when I did this u