Re: [PATCHES] [HACKERS] Implementation of SQLCODE and SQLERRM variables for

2005-04-18 Thread Tom Lane
Bruce Momjian writes: > Guys, is this patch ready for application? I think so, but am not 100% > sure. I haven't read the code yet, but in any case I still object to choosing Oracle-like names for Oracle-incompatible functionality. We need to settle on better names. reg

Re: [PATCHES] [HACKERS] Implementation of SQLCODE and SQLERRM variables for

2005-03-08 Thread Pavel Stehule
Hello, I changed code by your and Neil's notes. The name SQLCODE isn't well, better is SQLSTATE. It's very similar DB2 variable. I am not sure, so my solutions is best. Propably not. It's only particular solution for plpgsql. The files plpgsql.sql and plpgsql.out are diffs for regression tests.

Re: [PATCHES] [HACKERS] Implementation of SQLCODE and SQLERRM variables for

2005-03-07 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > - Is there a reason why you've made the type of SQLCODE `text', rather > than integer? The value isn't an integer ... which gets back to my point that this is not compatible with Oracle's idea of SQLCODE and therefore we should *not* use that name for it.

Re: [PATCHES] [HACKERS] Implementation of SQLCODE and SQLERRM variables for

2005-03-07 Thread Pavel Stehule
Hello, I used different format now. Documentation: This patch is implementation of variables SQLERRM and SQLCODE for plpgsql language. Variable SQLCODE contains five chars PostgreSQL Error Code, SQLERRM contains relevant message last catched exception. All variables are attached to plpgsql_blo

Re: [PATCHES] [HACKERS] Implementation of SQLCODE and SQLERRM variables for

2005-03-06 Thread Pavel Stehule
> > I think we discussed this last year and decided that it would be a bad > idea to use those names because Oracle's use of them is not exactly > compatible with our error codes and messages. SQLCODE in particular is > not compatible at all --- it's an integer in Oracle, isn't it? There is more

Re: [PATCHES] [HACKERS] Implementation of SQLCODE and SQLERRM variables for PL/pgSQL

2005-03-06 Thread Tom Lane
Pavel Stehule <[EMAIL PROTECTED]> writes: > This is my second patch, than please will be tolerant :-). For one my > project I miss information about exception when I use EXCEPTION WITH > OTHERS THEN. I found two Oracle's varaibles SQLCODE and SQLERRM which > carry this information. I think we