Re: [PATCHES] [HACKERS] Include Lists for Text Search

2008-03-10 Thread Teodor Sigaev
Right now I see an significant advantage of such layer: two possible extension of dictionary (filtering and storing original form) are One more extension: drop too long words. For example, decrease limit of max length of word to prevent long to be indexed - word with 100 characters is suspic

Re: [PATCHES] [HACKERS] Include Lists for Text Search

2008-03-10 Thread Teodor Sigaev
Well, if you think this can/should be done somewhere outside the dictionary, should I revert the applied patch? No, that patch is about case sensitivity of synonym dictionary. I suppose, Simon wants to replace 'bill' to 'account', but doesn't want to get 'account Clinton' For another dictiona

Re: [PATCHES] [HACKERS] Include Lists for Text Search

2008-03-10 Thread Tom Lane
Teodor Sigaev <[EMAIL PROTECTED]> writes: >> Hmm, I can see how some middleware would help with folding or not >> folding the input token, but what about the words coming from the >> dictionary file (particularly the *output* lexeme)? It's not apparent >> to me that it's sensible to try to control

Re: [PATCHES] [HACKERS] Include Lists for Text Search

2008-03-10 Thread Teodor Sigaev
Hmm, I can see how some middleware would help with folding or not folding the input token, but what about the words coming from the dictionary file (particularly the *output* lexeme)? It's not apparent to me that it's sensible to try to control that from outside the dictionary. Right now I see

Re: [PATCHES] [HACKERS] Include Lists for Text Search

2008-03-10 Thread Bruce Momjian
Andrew Dunstan wrote: > > > Simon Riggs wrote: > > As Greg mentions on another thread, not all patches are *intended* to be > > production quality by their authors. Many patches are shared for the > > purpose of eliciting general feedback. You yourself encourage a group > > development approach a

Re: [PATCHES] [HACKERS] Include Lists for Text Search

2008-03-10 Thread Simon Riggs
On Mon, 2008-03-10 at 10:01 -0400, Tom Lane wrote: > In future perhaps I should take it as a given that > Simon doesn't expect his patches to be applied? I think you should take it as a given that Simon would like to try to work together, sharing ideas and code, without insults and public derisio

Re: [PATCHES] [HACKERS] Include Lists for Text Search

2008-03-10 Thread Tom Lane
Oleg Bartunov <[EMAIL PROTECTED]> writes: > On Sun, 9 Mar 2008, Tom Lane wrote: >> Would a similar parameter be useful for any of the other dictionary >> types? > There are many things desirable to do with dictionaries, for example, > say dictionary to return an original word plus it's normal form

Re: [PATCHES] [HACKERS] Include Lists for Text Search

2008-03-10 Thread Simon Riggs
On Mon, 2008-03-10 at 09:42 -0400, Andrew Dunstan wrote: > I think if you post something marked Work In Progress, there is an > implied commitment on your part to post something complete at a later stage. > > So if it's forgotten you would be the one doing the forgetting. ;-) But if they aren't

Re: [PATCHES] [HACKERS] Include Lists for Text Search

2008-03-10 Thread Tom Lane
Andrew Dunstan <[EMAIL PROTECTED]> writes: > I think if you post something marked Work In Progress, there is an > implied commitment on your part to post something complete at a later stage. It *wasn't* marked Work In Progress, and Simon went out of his way to cross-post it to -patches, where the

Re: [PATCHES] [HACKERS] Include Lists for Text Search

2008-03-10 Thread Andrew Dunstan
Simon Riggs wrote: On Mon, 2008-03-10 at 08:24 -0400, Andrew Dunstan wrote: Simon Riggs wrote: As Greg mentions on another thread, not all patches are *intended* to be production quality by their authors. Many patches are shared for the purpose of eliciting general feedback. You yours

Re: [PATCHES] [HACKERS] Include Lists for Text Search

2008-03-10 Thread Simon Riggs
On Mon, 2008-03-10 at 08:24 -0400, Andrew Dunstan wrote: > > Simon Riggs wrote: > > As Greg mentions on another thread, not all patches are *intended* to be > > production quality by their authors. Many patches are shared for the > > purpose of eliciting general feedback. You yourself encourage a

Re: [PATCHES] [HACKERS] Include Lists for Text Search

2008-03-10 Thread Andrew Dunstan
Simon Riggs wrote: As Greg mentions on another thread, not all patches are *intended* to be production quality by their authors. Many patches are shared for the purpose of eliciting general feedback. You yourself encourage a group development approach and specifically punish those people droppi

Re: [PATCHES] [HACKERS] Include Lists for Text Search

2008-03-10 Thread Simon Riggs
On Sun, 2008-03-09 at 23:03 -0400, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > I've coded a small patch to allow CaseSensitive synonyms. > > Applied with corrections (it'd be good if you at least pretended to test > stuff before submitting it). It is a frequent accusation of you

Re: [PATCHES] [HACKERS] Include Lists for Text Search

2008-03-09 Thread Oleg Bartunov
On Sun, 9 Mar 2008, Tom Lane wrote: Simon Riggs <[EMAIL PROTECTED]> writes: I've coded a small patch to allow CaseSensitive synonyms. Applied with corrections (it'd be good if you at least pretended to test stuff before submitting it). Would a similar parameter be useful for any of the other

Re: [PATCHES] [HACKERS] Include Lists for Text Search

2008-03-09 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > I've coded a small patch to allow CaseSensitive synonyms. Applied with corrections (it'd be good if you at least pretended to test stuff before submitting it). Would a similar parameter be useful for any of the other dictionary types?

Re: [PATCHES] [HACKERS] Include Lists for Text Search

2007-09-26 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- Simon Riggs wrote: > On Mon, 2007-09-10 at 10:21 -0400, Tom Lane wrote: > > Oleg Bartunov <[EMAIL PROTECTED]> writes:

Re: [PATCHES] [HACKERS] Include Lists for Text Search

2007-09-10 Thread Simon Riggs
On Mon, 2007-09-10 at 10:21 -0400, Tom Lane wrote: > Oleg Bartunov <[EMAIL PROTECTED]> writes: > > On Mon, 10 Sep 2007, Simon Riggs wrote: > >> Can we include that functionality now? > > > This could be realized very easyly using dict_strict, which returns > > only known words, and mapping contain