Aizaz Ahmed <[EMAIL PROTECTED]> writes:
>> Good idea. Please send a patch that exports the guc.c array for use in
>> the other file. I'd lean towards the lower-cased spellings, though I'm
>> not strong about it. (I'd also not use a dash in "super-user".)
> I've attached the patch below. It modi
On Mon, 2003-07-28 at 10:57, Tom Lane wrote:
> Good idea. Please send a patch that exports the guc.c array for use in
> the other file. I'd lean towards the lower-cased spellings, though I'm
> not strong about it. (I'd also not use a dash in "super-user".)
I've attached the patch below. It modi
Patch applied. Thanks.
---
Joe Conway wrote:
> Bruce Momjian wrote:
> > Patch applied. Thanks.
> >
>
> There was enough code drift since this patch, that a couple of bugs
> materialized.
>
> New items have been added
On Sun, 2003-07-27 at 01:29, Joe Conway wrote:
> Bruce Momjian wrote:
> > Patch applied. Thanks.
> /*
> ! * Used for pg_settings. Keep in sync with config_type enum in guc_tables.h
>*/
> static char *config_type_name[] =
> {
> ***
> *** 176,181
> --- 176,182
>
Aizaz Ahmed <[EMAIL PROTECTED]> writes:
> looks like there's some duplication between this array and the
> static const char *const GucContext_names[] array in
> src/backend/utils/misc/help_config.c
> Is there some way we could have them both use the same array?
Good idea. Please send a patch th
Bruce Momjian wrote:
Patch applied. Thanks.
There was enough code drift since this patch, that a couple of bugs
materialized.
New items have been added to GucContext and GucSource enums, but of
course they were not added to the corresponding GucContextName[] and
GucSourceName[] arrays in the
Patch applied. Thanks.
---
Joe Conway wrote:
> I'm going to resend the patches that I have outstanding since it appears
> some may have been lost. Here's the third of three.
> =
Tom Lane wrote:
> Bruce Momjian <[EMAIL PROTECTED]> writes:
> > Tom Lane wrote:
> >> This reminds me, someone (Barry?) was griping that SHOW DATESTYLE
> >> doesn't produce a value that SET DATESTYLE will take. Did we agree
> >> that it was OK to change the output to look like "ISO, US" etc?
>
> >
Bruce Momjian <[EMAIL PROTECTED]> writes:
> Tom Lane wrote:
>> No, it's a DONE.
> I just tried this with CVS:
> test=> show datestyle;
> DateStyle
> ---
>ISO with US (NonEuropean) conventions
> (1 row)
Uh,
Oh, I see now. My new 'make check' script doesn't install a new version
in my standard path but just in the regression database.
I see what you see now.
---
Tom Lane wrote:
> Bruce Momjian <[EMAIL PROTECTED]> writes:
> > T
Bruce Momjian <[EMAIL PROTECTED]> writes:
> Tom Lane wrote:
>> This reminds me, someone (Barry?) was griping that SHOW DATESTYLE
>> doesn't produce a value that SET DATESTYLE will take. Did we agree
>> that it was OK to change the output to look like "ISO, US" etc?
> Is this a TODO?
No, it's a D
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---
Joe Conway wrote:
> I'm going to resend t
Tom Lane wrote:
> This reminds me, someone (Barry?) was griping that SHOW DATESTYLE
> doesn't produce a value that SET DATESTYLE will take. Did we agree
> that it was OK to change the output to look like "ISO, US" etc?
Is this a TODO?
--
Bruce Momjian| http://candle.p
I'm going to resend the patches that I have outstanding since it appears
some may have been lost. Here's the third of three.
===
Tom Lane wrote:
Joe Conway <[EMAIL PROTECTED]> writes:
ISTM that "source" is worth knowing.
Hm, possibly. Any other opi
Tom Lane wrote:
Joe Conway <[EMAIL PROTECTED]> writes:
ISTM that "source" is worth knowing.
Hm, possibly. Any other opinions?
This version has the seven fields I proposed, including "source". Here's
an example that shows why I think it's valuable:
regression=# \x
Expanded display is on.
regressi
Joe Conway <[EMAIL PROTECTED]> writes:
> ISTM that "source" is worth knowing.
Hm, possibly. Any other opinions?
>> This reminds me, someone (Barry?) was griping that SHOW DATESTYLE
>> doesn't produce a value that SET DATESTYLE will take. Did we agree
>> that it was OK to change the output to lo
Tom Lane wrote:
Joe Conway <[EMAIL PROTECTED]> writes:
Here is a patch to expand pg_settings. I included more than discussed
because it was easy and I thought it might be useful. Let me know if you
want some of them removed.
Much of what you've included is part of the internal implementation of
Joe Conway <[EMAIL PROTECTED]> writes:
> Here is a patch to expand pg_settings. I included more than discussed
> because it was easy and I thought it might be useful. Let me know if you
> want some of them removed.
Much of what you've included is part of the internal implementation of
GUC, and
(moved to PATCHES)
Tom Lane wrote:
I agree with this plan also. I'm not sure if the RH guys had intended
to get around to this or not --- it's not on their shortlist of stuff
they need for their tools.
The proposed patch from RH includes addition of descriptions to the
variables' table entries in
19 matches
Mail list logo
