Rocco Altier wrote:
This patch fixes the interval regression on my AIX box (kookaburra) by
only doing integer math on the interval, instead of float/double math.
I think this is the correct way to handle this, since it's an integer
data type.
I don't know if it will fix Olivier's problem,
This still does not fix the problem.
I had done my patch to try to mimic the way 8.0 had handled the math
with the remainders, but to carry it over another bucket (day).
The problem that I see is that we are taking day_remainder and
multiplying by USECS_PER_DAY. Which is a double * int64, thus
I just checked latest CVS (5 mn ago) the problem is still the same,
BTW, this is on Unixware 714 and no --enable-integer-datetime
Regards
On Sat, 23 Jul 2005, Rocco Altier wrote:
Date: Sat, 23 Jul 2005 11:15:44 -0400
From: Rocco Altier [EMAIL PROTECTED]
To: Bruce Momjian
ohp@pyrenet.fr wrote:
I just checked latest CVS (5 mn ago) the problem is still the same,
BTW, this is on Unixware 714 and no --enable-integer-datetime
Do you have the latest patch included int that version of CVS?
Anonymous CVS has a delay, and what was the problem you were seeing, the
On Sat, 23 Jul 2005, Bruce Momjian wrote:
Date: Sat, 23 Jul 2005 11:36:43 -0400 (EDT)
From: Bruce Momjian pgman@candle.pha.pa.us
To: ohp@pyrenet.fr
Cc: Rocco Altier [EMAIL PROTECTED],
Michael Glaesemann [EMAIL PROTECTED], pgsql-patches@postgresql.org,
pgsql-hackers@postgresql.org
I think the patch is ok now, intervall is not failing anymore as of
18:50 CET.
However stats fails.
regression.diffs:
*** ./expected/stats.outSat Jul 23 17:18:20 2005
--- ./results/stats.out Sat Jul 23 18:55:17 2005
***
*** 53,59
WHERE st.relname='tenk2' AND
Yes, we have seen those stat tests fail randomly. We are working on a
solution.
---
ohp@pyrenet.fr wrote:
I think the patch is ok now, intervall is not failing anymore as of
18:50 CET.
However stats fails.
Would you please try the attached patch and let me know if it fixes the
problem? I avoided accumulating into a float8.
---
Rocco Altier wrote:
This still does not fix the problem.
I had done my patch to try to mimic
That still does not fix it for me.
This patch is still using a computed float value (month_remainder and
day_remainder), which is cauing the rounding errors.
There are now 6 machines on the build farm that are failing from the
rounding:
Wallaroo (OSX/G4), asp(AIX/powerpc), viper(FC3/x86_64),
Rocco Altier wrote:
That still does not fix it for me.
This patch is still using a computed float value (month_remainder and
day_remainder), which is cauing the rounding errors.
There are now 6 machines on the build farm that are failing from the
rounding:
Wallaroo (OSX/G4),
Bruce Momjian wrote:
Rocco Altier wrote:
That still does not fix it for me.
This patch is still using a computed float value (month_remainder and
day_remainder), which is cauing the rounding errors.
There are now 6 machines on the build farm that are failing from the
rounding:
11 matches
Mail list logo
