Re: [PATCHES] [HACKERS] snprintf() argument reordering not working under Windows in 8.1

2005-12-03 Thread Nicolai Tufar
Greetings, I thought it will be as simple as changing Makefile, the issue seem to be much more complicated. Unfortunately I have no PostgreSQL building environment handy and will not be able to look at it until the end of next week because I am moving my house :( But since this issue waited for so

Re: [PATCHES] [HACKERS] snprintf() argument reordering not working under Windows in 8.1

2005-12-03 Thread Magnus Hagander
> Here is the commit: > > revision 1.409 > date: 2005/05/05 19:15:54; author: momjian; state: > Exp; lines: +8 -2 > On Win32, libintl replaces snprintf() with its own version that > understands arg control, so we don't need our own. In fact, it > also uses

Re: [PATCHES] [HACKERS] snprintf() argument reordering not working under Windows

2005-12-03 Thread Tom Lane
Bruce Momjian writes: > I am also thinking of modifying the code so if we are using snprintf.c > only because we need positional parameter control, we check for '$' in > the string and only use snprintf.c in those cases. What's the point? If the code is in there we may as well use it.

Re: [PATCHES] [HACKERS] snprintf() argument reordering not working under Windows

2005-12-03 Thread Bruce Momjian
Nicolai Tufar wrote: > Greetings, > > Last April we have made some changes to src/ports/snprintf.c so that it > would support argument reordering like %2$s, %1$d and such on > platforms where original snprintf() does not support it, like Windows, > HP-UX or NetBSD. Sure, I remember. So glad you