Re: [PATCHES] [pgsql-hackers-win32] Repleacement for src/port/snprintf.c

2005-03-11 Thread Bruce Momjian
I have reviewed this patch, and I already added these changes myself in CVS. Thanks. --- Nicolai Tufar wrote: > > On Mon, Feb 21, 2005 at 10:53:08PM -0500, Bruce Momjian wrote: > > > > Applied. > > Thanks a lot. The patch

Re: [PATCHES] [pgsql-hackers-win32] Repleacement for src/port/snprintf.c

2005-03-10 Thread Bruce Momjian
Would you please check current CVS? I think I addressed most of these issues already. --- Nicolai Tufar wrote: > > On Mon, Feb 21, 2005 at 10:53:08PM -0500, Bruce Momjian wrote: > > > > Applied. > > Thanks a lot. The patch

Re: [PATCHES] [pgsql-hackers-win32] Repleacement for src/port/snprintf.c

2005-02-25 Thread Nicolai Tufar
On Thu, 24 Feb 2005 22:18:11 -0500, Tom Lane <[EMAIL PROTECTED]> wrote: > Didn't we do that already? No :( I promised to do it a couple of weeks ago but could not get to do it. Now with Magnus's help I finaly did it. The last patch should be fine. > regards, tom lane Nic

Re: [PATCHES] [pgsql-hackers-win32] Repleacement for src/port/snprintf.c

2005-02-24 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Your patch has been added to the PostgreSQL unapplied patches list at: > > Didn't we do that already? This patch is for thread safety: > Thanks a lot. The patch attached solves the tread > safety problem. Please review it before applying, > I am not s

Re: [PATCHES] [pgsql-hackers-win32] Repleacement for src/port/snprintf.c

2005-02-24 Thread Tom Lane
Bruce Momjian writes: > Your patch has been added to the PostgreSQL unapplied patches list at: Didn't we do that already? regards, tom lane ---(end of broadcast)--- TIP 6: Have you searched our list archives?

Re: [PATCHES] [pgsql-hackers-win32] Repleacement for src/port/snprintf.c

2005-02-24 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Ni

Re: [PATCHES] [pgsql-hackers-win32] Repleacement for src/port/snprintf.c

2005-02-24 Thread Bruce Momjian
Tom Lane wrote: > Kurt Roeckx <[EMAIL PROTECTED]> writes: > > The configure test is a little broken. It needs to quote the > > $'s. > > > I've rewritten the test a little. > > Applied, thanks. Oops, Tom got to it first. (Darn!) :-) -- Bruce Momjian| http://candle.

Re: [PATCHES] [pgsql-hackers-win32] Repleacement for src/port/snprintf.c

2005-02-24 Thread Bruce Momjian
Oh, thanks. That is a great fix. Applied. Glad you could test it on a machine that supports positional parameters. --- Kurt Roeckx wrote: > On Mon, Feb 21, 2005 at 10:53:08PM -0500, Bruce Momjian wrote: > > > > Applied.

Re: [PATCHES] [pgsql-hackers-win32] Repleacement for src/port/snprintf.c

2005-02-23 Thread Tom Lane
Kurt Roeckx <[EMAIL PROTECTED]> writes: > The configure test is a little broken. It needs to quote the > $'s. > I've rewritten the test a little. Applied, thanks. regards, tom lane ---(end of broadcast)--- TIP 8: explain a

Re: [PATCHES] [pgsql-hackers-win32] Repleacement for src/port/snprintf.c

2005-02-22 Thread Kurt Roeckx
On Mon, Feb 21, 2005 at 10:53:08PM -0500, Bruce Momjian wrote: > > Applied. The configure test is a little broken. It needs to quote the $'s. I've rewritten the test a little. Kurt Index: config/c-library.m4 === RCS file: /proje

Re: [PATCHES] [pgsql-hackers-win32] Repleacement for src/port/snprintf.c

2005-02-21 Thread Bruce Momjian
Applied. --- Bruce Momjian wrote: > Nicolai Tufar wrote: > > Hello all, > > > > I would like to submit my changes to src/port/snprintf.c to > > enable %n$ format placeholder replacement in snprintf() and > > vsnprintf(). Ad

Re: [PATCHES] [pgsql-hackers-win32] Repleacement for src/port/snprintf.c

2005-02-15 Thread Nicolai Tufar
On Sun, 13 Feb 2005 19:06:34 -0500 (EST), Bruce Momjian wrote: > Anyway, this is too large to put into 8.0, but I am attaching a patch > for 8.1 that has the proper configure tests to check if the C library > supports this behavior. If it does not, the build will use our > port/snprintf.c. > One

Re: [PATCHES] [pgsql-hackers-win32] Repleacement for src/port/snprintf.c

2005-02-13 Thread Bruce Momjian
Nicolai Tufar wrote: > Hello all, > > I would like to submit my changes to src/port/snprintf.c to > enable %n$ format placeholder replacement in snprintf() and > vsnprintf(). Additionally I implemented a trivial printf(). > > I also attach a diff for configure.in to include snprintf.o > in pgport