Re: [PATCHES] [pgsql-hackers-win32] VC++ psql build broken

2004-09-28 Thread Bruce Momjian
Patch applied. Thanks. I had removed the "/I ..\..\include\port\win32" because I thought it wasn't needed anymore since I adjusted some include names, but I see it is needed. Thanks. --- Dave Page wrote: > > > > -

Re: [PATCHES] [pgsql-hackers-win32] VC++ psql build broken

2004-09-28 Thread Dave Page
> -Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf > Of Dave Page > Sent: 28 September 2004 12:06 > To: Bruce Momjian > Cc: PgSQL Win32 developers; PostgreSQL Patches > Subject: Re: [pgsql-hackers-win32] VC++ psql build broken > > - The crash I was se

Re: [PATCHES] [pgsql-hackers-win32] VC++ psql build broken

2004-09-28 Thread Dave Page
> -Original Message- > From: Bruce Momjian [mailto:[EMAIL PROTECTED] > Sent: 27 September 2004 23:58 > To: Dave Page > Cc: PgSQL Win32 developers; PostgreSQL Patches > Subject: Re: [pgsql-hackers-win32] VC++ psql build broken > > > I have fixed this issue with Dave's help. Hmm, not e

Re: [PATCHES] [pgsql-hackers-win32] VC++ psql build broken

2004-09-27 Thread Bruce Momjian
I have fixed this issue with Dave's help. --- Dave Page wrote: > > > > -Original Message- > > From: Bruce Momjian [mailto:[EMAIL PROTECTED] > > Sent: 12 September 2004 14:59 > > To: Dave Page > > Cc: PgSQL Win32

Re: [PATCHES] [pgsql-hackers-win32] VC++ psql build broken

2004-09-27 Thread Bruce Momjian
I have applied the attached patch. I changed psqlscan to only require flex when it needs to rebuild the flex output: psqlscan.c: psqlscan.l $(FLEX) -Cfe -opsqlscan.c psqlscan.l Because we normally ship the flex output in the tarball I didn't bother to document th

Re: [PATCHES] [pgsql-hackers-win32] VC++ psql build broken

2004-09-13 Thread Dave Page
> -Original Message- > From: Bruce Momjian [mailto:[EMAIL PROTECTED] > Sent: 12 September 2004 14:59 > To: Dave Page > Cc: PgSQL Win32 developers; PostgreSQL Patches > Subject: Re: [pgsql-hackers-win32] VC++ psql build broken > > > How does your Win32 system rename prototype differ fr

Re: [PATCHES] [pgsql-hackers-win32] VC++ psql build broken

2004-09-12 Thread Bruce Momjian
Andreas Pflug wrote: > Bruce Momjian wrote: > > Andreas Pflug wrote: > > > >>Bruce Momjian wrote: > >> > >>>How does your Win32 system rename prototype differ from what is in > >>>port.h? > >> > >>What is the need of *any* special file handling functions for client tools? > > > > > > We could av

Re: [PATCHES] [pgsql-hackers-win32] VC++ psql build broken

2004-09-12 Thread Andreas Pflug
Bruce Momjian wrote: Andreas Pflug wrote: Bruce Momjian wrote: How does your Win32 system rename prototype differ from what is in port.h? What is the need of *any* special file handling functions for client tools? We could avoid it but it does give us Unix semantics so it seemed good to keep it if

Re: [PATCHES] [pgsql-hackers-win32] VC++ psql build broken

2004-09-12 Thread Bruce Momjian
Andreas Pflug wrote: > Bruce Momjian wrote: > > How does your Win32 system rename prototype differ from what is in > > port.h? > > What is the need of *any* special file handling functions for client tools? We could avoid it but it does give us Unix semantics so it seemed good to keep it if we co

Re: [PATCHES] [pgsql-hackers-win32] VC++ psql build broken

2004-09-12 Thread Andreas Pflug
Bruce Momjian wrote: How does your Win32 system rename prototype differ from what is in port.h? What is the need of *any* special file handling functions for client tools? Regards, Andreas ---(end of broadcast)--- TIP 1: subscribe and unsubscribe comm

Re: [PATCHES] [pgsql-hackers-win32] VC++ psql build broken

2004-09-12 Thread Bruce Momjian
How does your Win32 system rename prototype differ from what is in port.h? extern int pgrename(const char *from, const char *to); extern int pgunlink(const char *path); Good question on wether we need to keep this working but it would be nice to keep it I guess for client-only

Re: [PATCHES] [pgsql-hackers-win32] VC++ psql build broken

2004-09-11 Thread Dave Page
> -Original Message- > From: Bruce Momjian [mailto:[EMAIL PROTECTED] > Sent: 10 September 2004 17:41 > To: [EMAIL PROTECTED] > Cc: Dave Page; PgSQL Win32 developers > Subject: Re: [pgsql-hackers-win32] VC++ psql build broken > > > Now that I think of it, flex will not work because the