Patch applied. Thanks.
---
Andrew Dunstan wrote:
> Note to self: stop working when brain is clearly malfunctioning.
>
> *This* patch works. Please disregard previous.
>
> thanks
>
> andrew
>
> Andrew Dunstan wrote:
>
Note to self: stop working when brain is clearly malfunctioning.
*This* patch works. Please disregard previous.
thanks
andrew
Andrew Dunstan wrote:
OK, this works.
cheers
andrew
Andrew Dunstan wrote:
ARRGGHH! It has a typo!. new patch shortly.
Andrew Dunstan wrote:
? initdb
Index: initd
OK, this works.
cheers
andrew
Andrew Dunstan wrote:
ARRGGHH! It has a typo!. new patch shortly.
Andrew Dunstan wrote:
Apologies. Here's the patch. There may be other very minor
differences in wording, too. But if that's all I missed I won't think
I did too badly :-)
cheers
andrew
Tom Lan
ARRGGHH! It has a typo!. new patch shortly.
Andrew Dunstan wrote:
Apologies. Here's the patch. There may be other very minor differences
in wording, too. But if that's all I missed I won't think I did too
badly :-)
cheers
andrew
Tom Lane wrote:
What's become of initdb's initial note about w
Apologies. Here's the patch. There may be other very minor differences
in wording, too. But if that's all I missed I won't think I did too
badly :-)
cheers
andrew
Tom Lane wrote:
What's become of initdb's initial note about who you are?
$ initdb
The files belonging to this database system wi
What's become of initdb's initial note about who you are?
$ initdb
The files belonging to this database system will be owned by user "postgres".
This user must also own the server process.
... etc etc...
The first two lines of printout don't seem to be in the "highly
compatible" C version.
Andrew Dunstan wrote:
>
>
> Andrew Dunstan wrote:
>
> >
> >
> >
> > The problem with this is that you now have 2 quoted strings.
>
>
> I take this back. You *can* have multiple quoted strings on the command
> line - it just doesn't work in popen() because it uses the /C flag.
Oh, OK, that's
Andrew Dunstan wrote:
The problem with this is that you now have 2 quoted strings.
I take this back. You *can* have multiple quoted strings on the command
line - it just doesn't work in popen() because it uses the /C flag.
Sorry for my confusion.
cheers
andrew
-
Bruce Momjian wrote:
I ran some tests using XP "CMD" and found:
"C:\test"
and
"\test"
works but:
"test"
does not work. Since I see that the output always has a leading path,
On Windows, pgpath is guaranteed to be a full path (see call to
expanded_path() ) exactly so it w
Andrew Dunstan wrote:
> >Good. I can do rmdir() in C in port/dirmod.c if we need it. Right now
> >we are doing system(rm/rmdir) in dbcommands.c so we should consistent.
> >Let's stay with system(rm/rmdir) and if it doesn't work as we expect, we
> >can add your rmdir() code and put it in port/dirm
Bruce Momjian wrote:
Andrew Dunstan wrote:
My comments:
I have no problem with shelling out to rmdir - although my goal was to
avoid shelling out to anything other than postgres itself. I think
recreating the datadir if we didn't create it initially should be OK in
that case, and it
Andrew Dunstan wrote:
>
>
> Bruce Momjian wrote:
>
> >Here is a slightly modified version of Andrew's great work in making a C
> >version of initdb. Other than minor cleanups, the only big change was
> >to remove rmdir handling because we using rm -r and rmdir /s in
> >commands/dbcommands.c, so
12 matches
Mail list logo
