Patch applied by Magnus.
---
ITAGAKI Takahiro wrote:
> The attached is a patch to define O_DIRECT by ourselves on Windows,
> and to map O_DIRECT to FILE_FLAG_NO_BUFFERING.
>
> There will be a consistency in our support betw
I've done some further looking aruond at this, and I've been unable to find
any references to disk systems with sector size > 8192 bytes (which is what
the alignment of the buffers per XLOG_BLCKSZ, at leastby default).
So I'll commit this fairly simple patch, and we'll revert it or add runtime
che
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.
---
IT
IIRC, we're still waiting for performance numbers showing there exists a
win from this patch.
//Magnus
Bruce Momjian wrote:
> Magnus, where are on this?
>
> ---
>
> Magnus Hagander wrote:
>> We're ok with the alignment issu
Magnus, where are on this?
---
Magnus Hagander wrote:
> We're ok with the alignment issues provided the is code added to reject
> O_DIRECT if the sector size is too large.
>
> We also said we need to see some performance nu
Are there any performance numbers on this?
---
ITAGAKI Takahiro wrote:
> The attached is a patch to define O_DIRECT by ourselves on Windows,
> and to map O_DIRECT to FILE_FLAG_NO_BUFFERING.
>
> There will be a consistency i