Re: [PATCHES] Add missing const qualifier in ECPG

2005-11-30 Thread Michael Meskes
I just applied most of your patch to 8.0, 8.1 and HEAD. The only thing I didn't is: diff -c -r1.7 memory.c *** ecpglib/memory.c15 Oct 2005 02:49:47 - 1.7 --- ecpglib/memory.c16 Nov 2005 00:40:57 - *** *** 11,17 void ECPGfree(void *ptr) { ! free(ptr);

Re: [PATCHES] Add missing const qualifier in ECPG

2005-11-15 Thread Qingqing Zhou
On Sun, 13 Nov 2005, Peter Eisentraut wrote: > > > > ! (*stmt)->command = (char *)query; > > (*stmt)->connection = connection; > > (*stmt)->lineno = lineno; > > (*stmt)->compat = compat; > > This sort of "cheating" should be avoided. > According to Peter's comment, revised patch is

Re: [PATCHES] Add missing const qualifier in ECPG

2005-11-12 Thread Qingqing Zhou
On Sat, 12 Nov 2005, Peter Eisentraut wrote: > Qingqing Zhou wrote: > > *** > > *** 149,155 > > if (!(*stmt = (struct statement *) ECPGalloc(sizeof(struct > > statement), lineno))) return false; > > > > ! (*stmt)->command = query; > > (*stmt)->connection = connection;

Re: [PATCHES] Add missing const qualifier in ECPG

2005-11-12 Thread Peter Eisentraut
Qingqing Zhou wrote: > *** > *** 149,155 > if (!(*stmt = (struct statement *) ECPGalloc(sizeof(struct > statement), lineno))) return false; > > ! (*stmt)->command = query; > (*stmt)->connection = connection; > (*stmt)->lineno = lineno; > (*stmt)->compat

[PATCHES] Add missing const qualifier in ECPG

2005-11-12 Thread Qingqing Zhou
Add missing const qualifier to (char *) parameters in ECPG. Per reported by Tomasz Ostrowski. Regards, Qingqing --- Index: ecpglib/descriptor.c === RCS file: /projects/cvsroot/pgsql/src/interfaces/ecpg/ecpglib/descriptor.c,v retrie