Re: [HACKERS] [PATCHES] Allow the identifier length to be increased via a configure option

2007-01-06 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Tom Lane wrote: >> ... why is NAMEDATALEN exported at all?) > I think because it used to be used in libpq's notification structure. Yeah, you're probably right. Maybe we should take it out of postgres_ext.h and move it to pg_config_manual.h. If no

Re: [HACKERS] [PATCHES] Allow the identifier length to be increased via a configure option

2007-01-06 Thread Peter Eisentraut
Tom Lane wrote: > I'm wondering how this got into the TODO list. It seems rather > pointless, and likely to create client compatibility problems (if > not, why is NAMEDATALEN exported at all?) I think because it used to be used in libpq's notification structure. -- Peter Eisentraut http://devel

Re: [PATCHES] Allow the identifier length to be increased via

2007-01-06 Thread Bruce Momjian
Dhanaraj M wrote: > Tom Lane wrote: > > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > > >> Dhanaraj M wrote: > >> > >>> I am sending the patch for the following TODO item: > >>> Allow the identifier length to be increased via a configure option > >>> > > > > > >> You should use p

Re: [PATCHES] Allow the identifier length to be increased via a

2006-12-28 Thread Dhanaraj M
Tom Lane wrote: Alvaro Herrera <[EMAIL PROTECTED]> writes: Dhanaraj M wrote: I am sending the patch for the following TODO item: Allow the identifier length to be increased via a configure option You should use pg_config.h, not mangle postgres_ext.h like that. Or maybe gen

Re: [PATCHES] Allow the identifier length to be increased via a configure option

2006-12-27 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Dhanaraj M wrote: >> I am sending the patch for the following TODO item: >> Allow the identifier length to be increased via a configure option > You should use pg_config.h, not mangle postgres_ext.h like that. Or > maybe generate postgres_ext.h from an

Re: [PATCHES] Allow the identifier length to be increased via a configure option

2006-12-27 Thread Alvaro Herrera
Dhanaraj M wrote: > I am sending the patch for the following TODO item: > Allow the identifier length to be increased via a configure option > > During the configuration time, the user can set the identifier length. > ./configure.txt --with-identlen=128 > > However, I am not clear about the requi

[PATCHES] Allow the identifier length to be increased via a configure option

2006-12-27 Thread Dhanaraj M
I am sending the patch for the following TODO item: Allow the identifier length to be increased via a configure option During the configuration time, the user can set the identifier length. ./configure.txt --with-identlen=128 However, I am not clear about the requirement. Can somebody review and