"Alon Goldshuv" <[EMAIL PROTECTED]> writes:
> Libpq copy speedup patch attached. No input buffer logic involved, just
> removing the expensive PQconsumeInput call per putCopyData call, and leaving
> parseInput as is, as discussed before.
Applied (with a better comment) to HEAD and 8.1 branches.
Libpq copy speedup patch attached. No input buffer logic involved, just
removing the expensive PQconsumeInput call per putCopyData call, and leaving
parseInput as is, as discussed before.
Alon.
libpq_copy.patch
Description: Binary data
---(end of broadcast)-
> You mean something like
>
> if (input-buffer-not-empty)
> parseInput();
>
> ? This still bothers me a bit since it's a mixing of logic levels;
> PQputCopyData is an output routine, it shouldn't be getting its fingers
> dirty with input buffer contents. I'm willing to tolerate this if it
> can
"Alon Goldshuv" <[EMAIL PROTECTED]> writes:
> I guess that although parseInput is cheap we could still use a conditional
> to see when data was sent and only then call it (without PQconsumeInput)
> instead of calling it every single time PQputCopyData is called. Any
> objection to that?
You mean s
Tom,
>> Here is a patch against today's code 1/24. As discussed in -hackers
>> consumeInput/parse is removed from being called every single time. It's
>> still there for only when the data is sent to the server.
>
> This appears to be the exact same patch you sent before. Did you
> test my sugge
"Alon Goldshuv" <[EMAIL PROTECTED]> writes:
> Here is a patch against today's code 1/24. As discussed in -hackers
> consumeInput/parse is removed from being called every single time. It's
> still there for only when the data is sent to the server.
This appears to be the exact same patch you sent b
Here is a patch against today's code 1/24. As discussed in -hackers
consumeInput/parse is removed from being called every single time. It's
still there for only when the data is sent to the server.
Alon.
pq_put_copy_data.patch
Description: Binary data
---(end of broadca
