Re: [PATCHES] Libpq ssl fix

2004-06-02 Thread Bruce Momjian
Patch applied. Thanks. --- Andreas Pflug wrote: > init_ssl_system will return 0 on success and -1 on failure, which will > be interpreted just the other way round in initialize_SSL. > Patch appended. > > Regards, > Andr

Re: [PATCHES] Libpq ssl fix

2004-05-28 Thread Bruce Momjian
You will find Anreas's two patches in the patch queue. Are there more changes than that? --- Manfred Spraul wrote: > Bruce Momjian wrote: > > >>- patch for thread_test.c needed posted some hours ago. > >> > >> > > > >A

Re: [PATCHES] Libpq ssl fix

2004-05-28 Thread Manfred Spraul
Bruce Momjian wrote: - patch for thread_test.c needed posted some hours ago. Applied. The current CVS tree work again, Andreas' patch fixed the configure failure. Additionally Andreas' libpq patch fixes ssl. I've tested the locking, too: ssl calls pq_lockingcallback. I've tested it by add

Re: [PATCHES] Libpq ssl fix

2004-05-28 Thread Tom Lane
Andreas Pflug <[EMAIL PROTECTED]> writes: > init_ssl_system will return 0 on success and -1 on failure, which will > be interpreted just the other way round in initialize_SSL. > Patch appended. Hmm, that looks backwards to me too, but this would seem to imply that Manfred Spraul failed to test h

Re: [PATCHES] Libpq ssl fix

2004-05-28 Thread Manfred Spraul
Hi, I'll retest the patch. I didn't have a working ssl test setup, thus I stopped when I ran into the same errors as without my patch. Probably printfs in initialize_SSL(), but no tests that the code beyond initialize_SSL() actually runs - sorry. Btw, --enable-thread-safety on Linux (RedHat Fed

Re: [PATCHES] Libpq ssl fix

2004-05-28 Thread Andreas Pflug
Tom Lane wrote: Andreas Pflug <[EMAIL PROTECTED]> writes: init_ssl_system will return 0 on success and -1 on failure, which will be interpreted just the other way round in initialize_SSL. Patch appended. Hmm, that looks backwards to me too, but this would seem to imply that Manfred Spraul

Re: [PATCHES] Libpq ssl fix

2004-05-28 Thread Bruce Momjian
Andreas Pflug wrote: > Manfred Spraul wrote: > > > > > > > Btw, --enable-thread-safety on Linux (RedHat Fedora Core 1) fails in > > configure with > > > >> configure: error: > >> *** Thread test program failed. Your platform is not thread-safe. > >> *** Check the file 'config.log'for the exact r

Re: [PATCHES] Libpq ssl fix

2004-05-28 Thread Andreas Pflug
Manfred Spraul wrote: Btw, --enable-thread-safety on Linux (RedHat Fedora Core 1) fails in configure with configure: error: *** Thread test program failed. Your platform is not thread-safe. *** Check the file 'config.log'for the exact reason. I had this too, for two reasons: - configure checks

[PATCHES] Libpq ssl fix

2004-05-28 Thread Andreas Pflug
init_ssl_system will return 0 on success and -1 on failure, which will be interpreted just the other way round in initialize_SSL. Patch appended. Regards, Andreas Index: fe-secure.c === RCS file: /projects/cvsroot/pgsql-server/src/i