Re: [PATCHES] Packed varlena patch update

2007-03-12 Thread Alvaro Herrera
Gregory Stark wrote: > I'm a bit worried about modules building against postgres.h without > including the config.h include file. Is that possible? Is it worth worrying > about? I think I could make it fail to build rather than crash randomly. postgres.h includes c.h which includes pg_confi

[PATCHES] Packed varlena patch update

2007-03-12 Thread Gregory Stark
I implemented Tom's suggestion of packing the external toast pointers unaligned and copying them to a local struct to access the fields. This saves 3-6 bytes on every external toast pointer. Presumably this isn't interesting if you're accessing the toasted values since they would be quite large