Re: [PATCHES] Preliminary patch for tsearch example dictionaries/parsers in contrib

2007-10-10 Thread Sergey V. Karpov
Tom Lane <[EMAIL PROTECTED]> writes: > [EMAIL PROTECTED] (Sergey V. Karpov) writes: >> Tom Lane <[EMAIL PROTECTED]> writes: >>> I think the consensus is for one module per top-level contrib directory. > >> Please excuse me, but English is not my native language, and I don't >> understand your phra

Re: [PATCHES] Preliminary patch for tsearch example dictionaries/parsers in contrib

2007-10-10 Thread Tom Lane
[EMAIL PROTECTED] (Sergey V. Karpov) writes: > Tom Lane <[EMAIL PROTECTED]> writes: >> I think the consensus is for one module per top-level contrib directory. > Please excuse me, but English is not my native language, and I don't > understand your phrase. Do you mean one module with two dictionar

Re: [PATCHES] Preliminary patch for tsearch example dictionaries/parsers in contrib

2007-10-10 Thread Sergey V. Karpov
Tom Lane <[EMAIL PROTECTED]> writes: > [EMAIL PROTECTED] (Sergey V. Karpov) writes: >> I've prepared reduced and renamed version of the examples. It may be >> downloaded at >> http://lynx.sao.ru/~karpov/tmp/ts_examples.tar.gz > >> - dict_xsyn now uses the same code to locate its config as built-

Re: [PATCHES] Preliminary patch for tsearch example dictionaries/parsers in contrib

2007-10-10 Thread Tom Lane
[EMAIL PROTECTED] (Sergey V. Karpov) writes: > I've prepared reduced and renamed version of the examples. It may be > downloaded at > http://lynx.sao.ru/~karpov/tmp/ts_examples.tar.gz > - dict_xsyn now uses the same code to locate its config as built-in >dictionaries, and can't access files

Re: [PATCHES] Preliminary patch for tsearch example dictionaries/parsers in contrib

2007-10-10 Thread Sergey V. Karpov
Tom Lane <[EMAIL PROTECTED]> writes: > Oleg Bartunov <[EMAIL PROTECTED]> writes: >> On Tue, 9 Oct 2007, Andrew Dunstan wrote: >>> Are we in beta or not? To me, beta means nothing but bug fixes go in, >>> period. No ifs, no buts, no maybes, no exceptions. And that should >>> definitely go for con

Re: [PATCHES] Preliminary patch for tsearch example dictionaries/parsers in contrib

2007-10-10 Thread Tom Lane
Oleg Bartunov <[EMAIL PROTECTED]> writes: > On Tue, 9 Oct 2007, Andrew Dunstan wrote: >> Are we in beta or not? To me, beta means nothing but bug fixes go in, >> period. No ifs, no buts, no maybes, no exceptions. And that should >> definitely go for contrib as well. We need a bit of self-discipli

Re: [PATCHES] Preliminary patch for tsearch example dictionaries/parsers in contrib

2007-10-09 Thread Oleg Bartunov
On Tue, 9 Oct 2007, Andrew Dunstan wrote: Sergey V. Karpov wrote: Built-in regex engine seems to not support the one feature critical to the dict_regex operation - it is not able to report the "partial match" in a case when the matching fails solely due to premature end of input string (i.e.

Re: [PATCHES] Preliminary patch for tsearch example dictionaries/parsers in contrib

2007-10-09 Thread Andrew Dunstan
Sergey V. Karpov wrote: Built-in regex engine seems to not support the one feature critical to the dict_regex operation - it is not able to report the "partial match" in a case when the matching fails solely due to premature end of input string (i.e. when matching may possibly succeed after add

Re: [PATCHES] Preliminary patch for tsearch example dictionaries/parsers in contrib

2007-10-09 Thread Sergey V. Karpov
Magnus Hagander <[EMAIL PROTECTED]> writes: >> > * Allowing config files to be read from anywhere is not acceptable. >> > We have dealt with this in the core code and the contrib examples >> > *must* follow the same rules. >> >> Is it necessary to require this behaviour from each contrib module?

Re: [PATCHES] Preliminary patch for tsearch example dictionaries/parsers in contrib

2007-10-09 Thread Magnus Hagander
On Tue, Oct 09, 2007 at 02:02:03PM +0400, Sergey V. Karpov wrote: > > Hi Tom, > > Thank you for starting the discussion > > > Given all the flap about txid, this surely mustn't go in without public > > review first ;-). So, here is a submission from Sergey Karpov to fill > > in the lack of any

Re: [PATCHES] Preliminary patch for tsearch example dictionaries/parsers in contrib

2007-10-09 Thread Sergey V. Karpov
Hi Tom, Thank you for starting the discussion > Given all the flap about txid, this surely mustn't go in without public > review first ;-). So, here is a submission from Sergey Karpov to fill > in the lack of any working code examples for user-written tsearch > parsers and dictionaries. > > I w

[PATCHES] Preliminary patch for tsearch example dictionaries/parsers in contrib

2007-10-08 Thread Tom Lane
Given all the flap about txid, this surely mustn't go in without public review first ;-). So, here is a submission from Sergey Karpov to fill in the lack of any working code examples for user-written tsearch parsers and dictionaries. I will be mostly off-line for the next day or so and don't have