Re: [PATCHES] Proposing correction to posix_fadvise() usage in xlog.c

2008-03-01 Thread Greg Smith
On Fri, 29 Feb 2008, Mark Wong wrote: Basically posix_fadvise() is being called right before the WAL segment file is closed, which effectively doesn't do anything as opposed to when the file is opened. This proposed correction calls posix_fadvise() in three locations... Actually,

[PATCHES] Proposing correction to posix_fadvise() usage in xlog.c

2008-02-29 Thread Mark Wong
I believe I have a correction to the usage of posix_fadvise() in xlog.c. Basically posix_fadvise() is being called right before the WAL segment file is closed, which effectively doesn't do anything as opposed to when the file is opened. This proposed correction calls posix_fadvise() in three