[PATCHES] Simplify Win32 Signaling code

2005-06-02 Thread Qingqing Zhou
This patch simplified Win32 signaling code per discussion in hackers. In this implementation, each process will have a named (by its pid) mutex, named shared memory area and named event in global namespace. The process is sending/receiving signals as the following: (*) the process who kill the si

Re: [PATCHES] Simplify Win32 Signaling code

2005-06-02 Thread Magnus Hagander
> This patch simplified Win32 signaling code per discussion in > hackers. In this implementation, each process will have a > named (by its pid) mutex, named shared memory area and named > event in global namespace. The process is sending/receiving > signals as the following: > > (*) the proces

Re: [PATCHES] Simplify Win32 Signaling code

2005-06-02 Thread Qingqing Zhou
""Magnus Hagander"" <[EMAIL PROTECTED]> writes > > Looking at this patch reminds me of another discussion we had: > > Signals sent by the postmaster *before the signaling code is running in > the child* has to be handled. > > This is handled in the curernt code by creating the pipe in the > postma

Re: [PATCHES] Simplify Win32 Signaling code

2005-06-02 Thread Qingqing Zhou
In thread: http://archives.postgresql.org/pgsql-hackers-win32/2004-11/msg00010.php --- >Do we actually need to pass the handle, or could the subprocess reopen >the pipe for itself? Nope, we need to pass the handle. Only one process can be the server-side of the pipe, and once the postmaster has o

Re: [PATCHES] Simplify Win32 Signaling code

2005-06-04 Thread Qingqing Zhou
Revised patch to avoid "lost signals before signaling mechanism is set up in Win32". This was tested by plus a line: Sleep(10*1000); in the front of pgwin32_signal_initialize(). Regards, Qingqing Index: src/port/kill.c ===

Re: [PATCHES] Simplify Win32 Signaling code

2005-06-04 Thread Magnus Hagander
Hi! A quick-check (haven't checked any details) - your unconditional use of Global\ will not work on NT4. With 8.0 we said we wanted to support NT4 with some limits (IIRC, tablespaces don't work, and the intaller definitly doesn't work). If we want to continue doing that (which I think we do), the

Re: [PATCHES] Simplify Win32 Signaling code

2005-06-04 Thread Bruce Momjian
Magnus Hagander wrote: > Hi! > > A quick-check (haven't checked any details) - your unconditional use of > Global\ will not work on NT4. With 8.0 we said we wanted to support NT4 > with some limits (IIRC, tablespaces don't work, and the intaller > definitly doesn't work). If we want to continue do

Re: [PATCHES] Simplify Win32 Signaling code

2005-06-04 Thread Magnus Hagander
>> Hi! >> >> A quick-check (haven't checked any details) - your >unconditional use of >> Global\ will not work on NT4. With 8.0 we said we wanted to >support NT4 >> with some limits (IIRC, tablespaces don't work, and the intaller >> definitly doesn't work). If we want to continue doing that (whi

Re: [PATCHES] Simplify Win32 Signaling code

2005-06-04 Thread Bruce Momjian
Magnus Hagander wrote: > >> Hi! > >> > >> A quick-check (haven't checked any details) - your > >unconditional use of > >> Global\ will not work on NT4. With 8.0 we said we wanted to > >support NT4 > >> with some limits (IIRC, tablespaces don't work, and the intaller > >> definitly doesn't work).

Re: [PATCHES] Simplify Win32 Signaling code

2005-06-04 Thread Magnus Hagander
>> >> A quick-check (haven't checked any details) - your >> >unconditional use of >> >> Global\ will not work on NT4. With 8.0 we said we wanted to >> >support NT4 >> >> with some limits (IIRC, tablespaces don't work, and the intaller >> >> definitly doesn't work). If we want to continue doing >

Re: [PATCHES] Simplify Win32 Signaling code

2005-06-05 Thread Qingqing Zhou
""Magnus Hagander"" <[EMAIL PROTECTED]> writes > > It *must* be done at runtime. Because you use the same binary on NT4 and > more recent versions! > > Nope, we don't have any checks like that today. It's fairly trivial, but > if examples are needed, look at pginstca.c in the pginstaller project >