I'm fine with Tom's wording and placement.
This seems a bit wordy, as well as wrongly placed --- the time to tell
people they need a non-multithreaded Tcl is in the installation
instructions. I added the following instead.
regards, tom lane
---
"Marshall, Steve" <[EMAIL PROTECTED]> writes:
> Bruce Momjian wrote:
>> Can you send in a patch against pltcl.sgml?
>>
> PL/TCL documentation patch is attached.
This seems a bit wordy, as well as wrongly placed --- the time to tell
people they need a non-multithreaded Tcl is in the installation
i
Bruce Momjian wrote:
Marshall, Steve wrote:
The recent TCL patch assumed Tcl_NotifierProcs.initNotifierProc
was added in TCL 8.2:
In fact it was added in 8.4 so I have modified the CVS with
the following patch.
I confirmed this against the 8.2.5 release. Sorry I did not notice that
Bruce Momjian <[EMAIL PROTECTED]> writes:
> Marshall, Steve wrote:
>> This is probably not a big problem, since TCL was not commonly compiled
>> with multithreading enabled prior to 8.4. However, perhaps there should
>> be a warning in the documentation on PL/TCL directing users to avoid
>> linkin
Marshall, Steve wrote:
> >The recent TCL patch assumed Tcl_NotifierProcs.initNotifierProc
> >was added in TCL 8.2:
> >In fact it was added in 8.4 so I have modified the CVS with
> >the following patch.
>
> I confirmed this against the 8.2.5 release. Sorry I did not notice that
> when I initiall
Matt Newell wrote:
> On Friday 28 September 2007 14:04, Bruce Momjian wrote:
> > ** 178,184
> >* within Postgres, but we implement all the functions for completeness.
> >* We can only fix this with Tcl >= 8.2, when Tcl_SetNotifier() appeared.
> >*/
> > ! #if HAVE_TCL_VERSION(8,2)
>
On Friday 28 September 2007 14:04, Bruce Momjian wrote:
> ** 178,184
>* within Postgres, but we implement all the functions for completeness.
>* We can only fix this with Tcl >= 8.2, when Tcl_SetNotifier() appeared.
>*/
> ! #if HAVE_TCL_VERSION(8,2)
You missed the 8.2 in the comme
>The recent TCL patch assumed Tcl_NotifierProcs.initNotifierProc
>was added in TCL 8.2:
>In fact it was added in 8.4 so I have modified the CVS with
>the following patch.
I confirmed this against the 8.2.5 release. Sorry I did not notice that
when I initially created the patch.
While the patch
The recent TCL patch assumed Tcl_NotifierProcs.initNotifierProc was
added in TCL 8.2:
#if HAVE_TCL_VERSION(8,2)
/*
* Override the functions in the Notifier subsystem. See comments
above.
*/
{
Tcl_NotifierProcs notifier;
