[PATCHES] Tablespaces

2004-05-27 Thread Gavin Sherry
Hi all, Attached is my latest patch implementing tablespaces. This has all the functionality I was planning for 7.5. Most of the information about the patch is contained in the patch/documentation, previous submissions and the archives. Testing, review, comments would be greatly appreciated. Ga

Re: [PATCHES] Tablespaces

2004-05-27 Thread Christopher Kings-Lynne
Compile error? gmake[2]: Entering directory `/space/1/home/chriskl/pgsql-server/src/timezone' gcc -O2 -fno-strict-aliasing -g -Wall -Wmissing-prototypes -Wmissing-declarations -I../../src/include -c -o pgtz.o pgtz.c -MMD In file included from ../../src/include/storage/bufmgr.h:20,

Re: [PATCHES] Tablespaces

2004-05-27 Thread Neil Conway
Gavin Sherry wrote: Attached is my latest patch implementing tablespaces. This has all the functionality I was planning for 7.5. A few minor points I happened to notice while reading through the patch: + * To simply initialisation and XLog activity, have create and maintain + * a symbolic link m

Re: [PATCHES] Tablespaces

2004-05-27 Thread Gavin Sherry
Attached is an updated patch, fixing a compile error which my compiler didn't seem to detect/suffer from and incorporating fixes to problems raised by Neil. Thanks, Gavin tablespace-20.diff.gz Description: GNU Zip compressed data ---(end of broadcast)---

Re: [PATCHES] Tablespaces

2004-06-05 Thread Christopher Kings-Lynne
Just reminding someone to review this some time...it does all seem to work very well :) Chris Gavin Sherry wrote: Attached is an updated patch, fixing a compile error which my compiler didn't seem to detect/suffer from and incorporating fixes to problems raised by Neil. Thanks, Gavin

Re: [PATCHES] Tablespaces

2004-06-05 Thread Bruce Momjian
Yes, I was wondering if it was ready for application. Tom, you want to eyeball it? --- Christopher Kings-Lynne wrote: > Just reminding someone to review this some time...it does all seem to > work very well :) > > Chris >

Re: [PATCHES] Tablespaces

2004-06-05 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Yes, I was wondering if it was ready for application. Tom, you want to > eyeball it? I do. I'd like to get the composite-type-column stuff out of the way first, and then I'll buckle down to reviewing patches (this one and the other major patches in the

Re: [PATCHES] Tablespaces

2004-06-09 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it after review.. --- Gavin Sherry wrote: > Attached is an updated patch,

Re: [PATCHES] Tablespaces

2004-06-16 Thread Tom Lane
I'm starting to review this patch, and almost immediately came across what seemed a spectacularly bad idea: *** src/backend/storage/buffer/bufmgr.c8 May 2004 19:09:25 -1.165 --- src/backend/storage/buffer/bufmgr.c26 May 2004 06:21:01 - *** *** 1148,1152

Re: [PATCHES] Tablespaces

2004-06-16 Thread Gavin Sherry
Hi Tom, On Wed, 16 Jun 2004, Tom Lane wrote: > I'm starting to review this patch, and almost immediately came across > what seemed a spectacularly bad idea: > > *** src/backend/storage/buffer/bufmgr.c8 May 2004 19:09:25 -1.165 > --- src/backend/storage/buffer/bufmgr.c26 May 2004 0

Re: [PATCHES] Tablespaces

2004-06-20 Thread Simon Riggs
On Thu, 2004-05-27 at 07:59, Gavin Sherry wrote: > Attached is my latest patch implementing tablespaces. This has all the > functionality I was planning for 7.5. > > Most of the information about the patch is contained in the > patch/documentation, previous submissions and the archives. > > Testi

Re: [PATCHES] Tablespaces

2004-06-20 Thread Gavin Sherry
On Sun, 20 Jun 2004, Simon Riggs wrote: > On Thu, 2004-05-27 at 07:59, Gavin Sherry wrote: > > Attached is my latest patch implementing tablespaces. This has all the > > functionality I was planning for 7.5. > > > > Most of the information about the patch is contained in the > > patch/documentatio

Re: [PATCHES] Tablespaces

2004-06-20 Thread Tom Lane
Simon Riggs <[EMAIL PROTECTED]> writes: > I've reviewed your patch by eye, but can't see anything in your patch > about relocating the pg_xlog directory. I see no reasonable way to move pg_xlog while the postmaster is up. So this is something that will always require outside-the-database activity.

Re: [PATCHES] Tablespaces

2004-06-20 Thread Simon Riggs
On Sun, 2004-06-20 at 22:28, Tom Lane wrote: > Simon Riggs <[EMAIL PROTECTED]> writes: > > There was/is a TODO item: > > - Allow xlog directory location to be specified during initdb, perhaps > > using symlinks > > Note this says "during initdb", which is a whole different ballgame. > We could ce