Re: [PATCHES] UPDATE using sub selects

2008-03-18 Thread Bruce Momjian
Patch removed from patch queue --- NikhilS, please resubmit when you are ready. Thanks. --- NikhilS wrote: > Hi, > > As per discussion on -hackers, a patch which allows updates to use > subselects is attached with this mai

Re: [PATCHES] UPDATE using sub selects

2008-03-18 Thread NikhilS
Hi Tom, > ... eg backend/nodes/, optimizer/util/clauses.c, ruleutils.c...) > > Actually, on further thought ruleutils.c represents one of the biggest > stumbling blocks here. We have to be able to reverse-compile the parse > tree into something that's at least semantically equivalent to the > ori

Re: [PATCHES] UPDATE using sub selects

2008-03-17 Thread Tom Lane
I wrote: > ... eg backend/nodes/, optimizer/util/clauses.c, ruleutils.c...) Actually, on further thought ruleutils.c represents one of the biggest stumbling blocks here. We have to be able to reverse-compile the parse tree into something that's at least semantically equivalent to the original que

Re: [PATCHES] UPDATE using sub selects

2008-03-17 Thread Tom Lane
NikhilS <[EMAIL PROTECTED]> writes: > As per discussion on -hackers, a patch which allows updates to use > subselects is attached with this mail. I looked over this patch briefly, and I'm afraid it still needs a lot of work. The way you altered transformUpdateStmt is a mess; it's duplicating logi

Re: [PATCHES] UPDATE using sub selects

2007-04-26 Thread Bruce Momjian
This has been saved for the 8.4 release: http://momjian.postgresql.org/cgi-bin/pgpatches_hold --- NikhilS wrote: > Hi, > > As per discussion on -hackers, a patch which allows updates to use > subselects is attached

[PATCHES] UPDATE using sub selects

2007-04-11 Thread NikhilS
Hi, As per discussion on -hackers, a patch which allows updates to use subselects is attached with this mail. As per discussion with Tom, I have adopted the following approach: * Introduce ROWEXPR_SUBLINK type for subqueries that allows multiple column outputs. * Populate the targetList with PA