Re: [PATCHES] Warning is adjusted of pgbench.

2007-09-27 Thread Hiroshi Saito
Hi. From: "Tom Lane" <[EMAIL PROTECTED]> Magnus Hagander <[EMAIL PROTECTED]> writes: On Tue, Aug 07, 2007 at 04:58:19PM +0900, Hiroshi Saito wrote: pgbench.c: In function `main': pgbench.c:1257: warning: implicit declaration of function `getopt' adjustment of some reference is required for t

Re: [PATCHES] Warning is adjusted of pgbench.

2007-09-27 Thread Hiroshi Saito
Hi. - Original Message - From: "Tom Lane" <[EMAIL PROTECTED]> Magnus Hagander <[EMAIL PROTECTED]> writes: On Thu, Sep 27, 2007 at 03:21:59PM +0900, Hiroshi Saito wrote: What do you think? I will be offline for most of the time for a couple of days, so it will probably be until e

Re: [PATCHES] Warning is adjusted of pgbench.

2007-09-27 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > On Tue, Aug 07, 2007 at 04:58:19PM +0900, Hiroshi Saito wrote: >> pgbench.c: In function `main': >> pgbench.c:1257: warning: implicit declaration of function `getopt' >> >> adjustment of some reference is required for this. > Why do you need to #undef

Re: [PATCHES] Warning is adjusted of pgbench.

2007-09-27 Thread Tom Lane
Magnus Hagander <[EMAIL PROTECTED]> writes: > On Thu, Sep 27, 2007 at 03:21:59PM +0900, Hiroshi Saito wrote: >> What do you think? > I will be offline for most of the time for a couple of days, so it will > probably be until early next week before I can look at this. Just a FYI, > but I'll be hap

Re: [PATCHES] Warning is adjusted of pgbench.

2007-09-27 Thread Magnus Hagander
On Thu, Sep 27, 2007 at 03:21:59PM +0900, Hiroshi Saito wrote: > Hi. > > >>To be clear: my thought is to put "#define FRONTEND 1" into > >>postgres_fe.h and then eliminate ad-hoc definitions of it from a > >>boatload of Makefiles. A quick grep suggests that the only place this > >>wouldn't work t

Re: [PATCHES] Warning is adjusted of pgbench.

2007-09-26 Thread Hiroshi Saito
Hi. To be clear: my thought is to put "#define FRONTEND 1" into postgres_fe.h and then eliminate ad-hoc definitions of it from a boatload of Makefiles. A quick grep suggests that the only place this wouldn't work too well is src/port/, but that could keep on doing what it's doing. I tried it.

Re: [PATCHES] Warning is adjusted of pgbench.

2007-09-25 Thread Hiroshi Saito
Hi. From: "Tom Lane" <[EMAIL PROTECTED]> "Hiroshi Saito" <[EMAIL PROTECTED]> writes: From: "Tom Lane" <[EMAIL PROTECTED]> Perhaps instead postgres_fe.h should #define FRONTEND? Yes, I feared that the physique of a main part broke. Then, Magnus said the same suggestion as you. It seems th

Re: [PATCHES] Warning is adjusted of pgbench.

2007-09-25 Thread Tom Lane
"Hiroshi Saito" <[EMAIL PROTECTED]> writes: > From: "Tom Lane" <[EMAIL PROTECTED]> >> Perhaps instead postgres_fe.h should #define FRONTEND? > Yes, I feared that the physique of a main part broke. Then, Magnus said the > same suggestion as you. It seems that it needs to be brushup. > I am going

Re: [PATCHES] Warning is adjusted of pgbench.

2007-09-25 Thread Hiroshi Saito
Hi. From: "Tom Lane" <[EMAIL PROTECTED]> "Hiroshi Saito" <[EMAIL PROTECTED]> writes: Why do you need to #undef EXEC_BACKEND, and is there a specific reason for removing the include of win32.h? I put in in order to avoid -D of the Makefile. If that matters, the problem is that somebody pu

Re: [PATCHES] Warning is adjusted of pgbench.

2007-09-25 Thread Tom Lane
"Hiroshi Saito" <[EMAIL PROTECTED]> writes: >> Why do you need to #undef EXEC_BACKEND, and is there a specific reason for >> removing the include of win32.h? > I put in in order to avoid -D of the Makefile. If that matters, the problem is that somebody put the wrong stuff in the wrong include fil

Re: [PATCHES] Warning is adjusted of pgbench.

2007-08-07 Thread Hiroshi Saito
Hi. Magnus $ make gcc -O2 -Wall -Wmissing-prototypes -Wpointer-arith -Winline -Wdeclaration-after-statement -Wendif-labels -fno-strict-aliasing -I../../src/interfaces/libpq -I. -I../../src/include -I./src/include/port/win32 -DEXEC_BACKEND "-I../../src/include/port/win32" -c -o pgbench.o pgben

Re: [PATCHES] Warning is adjusted of pgbench.

2007-08-07 Thread Magnus Hagander
On Tue, Aug 07, 2007 at 04:58:19PM +0900, Hiroshi Saito wrote: > Hi Magnus. > > pgbench.c: In function `main': > pgbench.c:1257: warning: implicit declaration of function `getopt' > > adjustment of some reference is required for this. > and this is a FRONTEND program. > patch is smooth at VC8 and

[PATCHES] Warning is adjusted of pgbench.

2007-08-07 Thread Hiroshi Saito
Hi Magnus. pgbench.c: In function `main': pgbench.c:1257: warning: implicit declaration of function `getopt' adjustment of some reference is required for this. and this is a FRONTEND program. patch is smooth at VC8 and MinGW (gcc). Regards, Hiroshi Saito pgbench_patch Description: Binary data