Re: [PATCHES] Yet more tsearch refactoring

2007-09-11 Thread Gregory Stark
"Teodor Sigaev" <[EMAIL PROTECTED]> writes: > Did you check it on 64-bit boxes with strict alignment? I remember that was a > headache for me. Is there a regression test which would fail if this kind of problem crops up? Not every developer can test every type of hardware but (aside from believin

Re: [PATCHES] Yet more tsearch refactoring

2007-09-10 Thread Heikki Linnakangas
Teodor Sigaev wrote: > Heikki Linnakangas wrote: >> * Defined new struct WordEntryPosVector that holds a uint16 length and a >> variable size array of WordEntries. This replaces the previous >> convention of a variable size uint16 array, with the first element >> implying the length. WordEntryPosVe

Re: [PATCHES] Yet more tsearch refactoring

2007-09-10 Thread Teodor Sigaev
Heikki Linnakangas wrote: * Defined new struct WordEntryPosVector that holds a uint16 length and a variable size array of WordEntries. This replaces the previous convention of a variable size uint16 array, with the first element implying the length. WordEntryPosVector has the same layout in mem

[PATCHES] Yet more tsearch refactoring

2007-09-10 Thread Heikki Linnakangas
* Defined new struct WordEntryPosVector that holds a uint16 length and a variable size array of WordEntries. This replaces the previous convention of a variable size uint16 array, with the first element implying the length. WordEntryPosVector has the same layout in memory, but is more readable in s