Re: [PATCHES] add additional options to CREATE TABLE ... AS

2006-02-18 Thread Neil Conway
On Tue, 2006-02-14 at 14:32 -0500, Kris Jurka wrote: > This patch adds most of the options available for regular CREATE TABLE > syntax to the CREATE TABLE x AS SELECT ... and AS EXECUTE ... Applied to HEAD, including the documentation updates posted separately. Thanks for the patch. -Neil --

Re: [PATCHES] add additional options to CREATE TABLE ... AS

2006-02-18 Thread Neil Conway
On Tue, 2006-02-14 at 14:32 -0500, Kris Jurka wrote: > This patch adds most of the options available for regular CREATE TABLE > syntax to the CREATE TABLE x AS SELECT ... and AS EXECUTE ... Barring any objections, I'll apply this later today or tomorrow. -Neil ---(end

Re: [PATCHES] add additional options to CREATE TABLE ... AS

2006-02-15 Thread Simon Riggs
On Tue, 2006-02-14 at 15:38 -0500, Tom Lane wrote: > Neil Conway <[EMAIL PROTECTED]> writes: > > The implementation is pretty ugly -- it clutters ExecuteStmt and Query > > with fields that really do not belong there. Per previous discussion, I > > think it would be better to refactor the CREATE TAB

Re: [PATCHES] add additional options to CREATE TABLE ... AS

2006-02-14 Thread Kris Jurka
On Tue, 14 Feb 2006, Tom Lane wrote: I kinda wonder why bother at all. I don't see any good reason why people shouldn't issue two statements. Well if you don't know what the resulting columns are going to be that could be difficult. There are a number of reasons why this patch is an imp

Re: [PATCHES] add additional options to CREATE TABLE ... AS

2006-02-14 Thread Kris Jurka
On Tue, 14 Feb 2006, Kris Jurka wrote: This patch adds most of the options available for regular CREATE TABLE syntax to the CREATE TABLE x AS SELECT ... and AS EXECUTE ... Here's the doc changes for this. Kris JurkaIndex: doc/src/sgml/ref/create_table_as.sgml =

Re: [PATCHES] add additional options to CREATE TABLE ... AS

2006-02-14 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > The implementation is pretty ugly -- it clutters ExecuteStmt and Query > with fields that really do not belong there. Per previous discussion, I > think it would be better to refactor the CREATE TABLE AS implementation > to be essentially a CREATE TABLE fol

Re: [PATCHES] add additional options to CREATE TABLE ... AS

2006-02-14 Thread Neil Conway
On Tue, 2006-02-14 at 14:32 -0500, Kris Jurka wrote: > This patch adds most of the options available for regular CREATE TABLE > syntax to the CREATE TABLE x AS SELECT ... and AS EXECUTE ... > Specifically this allows specification of on commit behavior for temp > tables and tablespaces for regul

[PATCHES] add additional options to CREATE TABLE ... AS

2006-02-14 Thread Kris Jurka
This patch adds most of the options available for regular CREATE TABLE syntax to the CREATE TABLE x AS SELECT ... and AS EXECUTE ... Specifically this allows specification of on commit behavior for temp tables and tablespaces for regular tables to these two statements. Additionally with/witho