Re: [PATCHES] archiver.pid

2006-05-30 Thread Bruce Momjian
Patch applied to CVS HEAD and 8.1.X. Thanks. --- Simon Riggs wrote: > On Mon, 2006-05-22 at 17:29 +0100, Simon Riggs wrote: > > Lock file to prevent starting with multiple archivers present. > > > > Possibly some debate o

Re: [PATCHES] archiver.pid

2006-05-23 Thread Simon Riggs
On Mon, 2006-05-22 at 17:29 +0100, Simon Riggs wrote: > Lock file to prevent starting with multiple archivers present. > > Possibly some debate over exact behaviour, but publish early... Original patch withdrawn. New patch included. -- Simon Riggs EnterpriseDB http://www.ent

Re: [PATCHES] archiver.pid

2006-05-22 Thread Alvaro Herrera
Simon Riggs wrote: > Lock file to prevent starting with multiple archivers present. Isn't it cleaner to remove the PID file in postmaster.c:reaper()? That way you are really sure that the PID file is removed when the process is gone, even if it crashes. OTOH I don't think it's very clean to chan

[PATCHES] archiver.pid

2006-05-22 Thread Simon Riggs
Lock file to prevent starting with multiple archivers present. Possibly some debate over exact behaviour, but publish early... -- Simon Riggs EnterpriseDB http://www.enterprisedb.com Index: src/backend/postmaster/pgarch.c ===