I'll look on it
From: Bruce Momjian <[EMAIL PROTECTED]>
To: Andrew Dunstan <[EMAIL PROTECTED]>
CC: Pavel Stehule <[EMAIL PROTECTED]>,
pgsql-patches@postgresql.org, [EMAIL PROTECTED]
Subject: Re: [PATCHES] better support of out parameters in plperl
Date: Thu, 8 Feb 2
This patch has been rejected based on comments just made by Andrew
Dunstan. If the author wants to revisit that, please reply and we can
discuss the issues.
---
Andrew Dunstan wrote:
>
>
> I wrote:
> > Pavel Stehule wrote
Andrew Dunstan wrote:
>
> Has it been resubmitted with issues attended to? If it has, I missed it.
> If not, why should someone else waste time on something so broken that
> it produced a stringified perl hashref on output? It should never have
> gone back in the queue IMNSHO.
Fine, removed.
Has it been resubmitted with issues attended to? If it has, I missed it.
If not, why should someone else waste time on something so broken that
it produced a stringified perl hashref on output? It should never have
gone back in the queue IMNSHO.
cheers
andrew
Bruce Momjian wrote:
Would s
Would someone review this. It is in the patches_hold queue:
http://momjian.postgresql.org/cgi-bin/pgpatches_hold
---
Andrew Dunstan wrote:
>
> I think it has to wait to 8.3. It's a complete mess that was submitted
Bruce Momjian <[EMAIL PROTECTED]> writes:
> Uh, were are we in fixing/reviewing this?
It's dead for 8.2 --- Andrew's complaints are pretty serious at both
the conceptual and implementation levels, and there's been no sign of
discussion about how to fix them.
regards, tom l
Like I said, at the last moment.
Bruce Momjian wrote:
Oh, let me add that this was first discussed on July 28:
http://archives.postgresql.org/pgsql-hackers/2006-07/msg01421.php
and a patch posted on July 30:
http://archives.postgresql.org/pgsql-hackers/2006-07/msg01559.php
Oh, let me add that this was first discussed on July 28:
http://archives.postgresql.org/pgsql-hackers/2006-07/msg01421.php
and a patch posted on July 30:
http://archives.postgresql.org/pgsql-hackers/2006-07/msg01559.php
--
OK.
This has been saved for the 8.3 release:
http://momjian.postgresql.org/cgi-bin/pgpatches_hold
---
Andrew Dunstan wrote:
>
> I think it has to wait to 8.3. It's a complete mess that was submitted
> unheralded
I think it has to wait to 8.3. It's a complete mess that was submitted
unheralded at the last moment. Pavel needs to get into the habit of
submitting ideas first, not just patches. And there must be proper
documentation and working regression tests.
cheers
andrew
Bruce Momjian wrote:
Uh,
Uh, were are we in fixing/reviewing this?
---
Andrew Dunstan wrote:
>
>
> I wrote:
> > Pavel Stehule wrote:
> >> Hello,
> >>
> >> I send two small patches. First does conversion from perl to
> >> postgresql array in OUT p
Based on this analysis, and problems with differing regression results
on different platforms, this attached patch has been reverted.
---
Andrew Dunstan wrote:
>
>
> I wrote:
> > Pavel Stehule wrote:
> >> Hello,
> >>
> >>
I wrote:
Pavel Stehule wrote:
Hello,
I send two small patches. First does conversion from perl to
postgresql array in OUT parameters. Second patch allow hash form
output from procedures with one OUT argument.
I will try to review these in the next 2 weeks unless someone beats me
to it.
Patch applied. Thanks.
---
Pavel Stehule wrote:
> Hello,
>
> I send two small patches. First does conversion from perl to postgresql
> array in OUT parameters. Second patch allow hash form output from procedures
> with
Pavel Stehule wrote:
Hello,
I send two small patches. First does conversion from perl to
postgresql array in OUT parameters. Second patch allow hash form
output from procedures with one OUT argument.
I will try to review these in the next 2 weeks unless someone beats me
to it.
cheers
a
Hello,
I send two small patches. First does conversion from perl to postgresql
array in OUT parameters. Second patch allow hash form output from procedures
with one OUT argument.
Regards
Pavel Stehule
_
Citite se osamele? Poznej
16 matches
Mail list logo
