Neil Conway [EMAIL PROTECTED] writes:
This patch makes various cosmetic improvements to the timezone code:
remove the use of the register qualifier, make some function declaration
syntax a bit more consistent, etc.
I think mostly what you are doing here is causing code drift from the
Tom Lane wrote:
I think mostly what you are doing here is causing code drift from the
upstream zic code. I don't think that's a very good idea, since we
do need to be able to track and apply bug fixes from them from time
to time ...
Why run pgindent on the timezone code, then? That seems
Tom Lane wrote:
Well, it's certainly hopeless to expect patch to fix it :-(. But the
further the code drifts the harder it gets to compare manually.
Sure, but I don't see how removing a few register qualifiers and so
forth is going to make the slightest difference to a manual comparison.
If
Tom Lane wrote:
Neil Conway [EMAIL PROTECTED] writes:
Tom Lane wrote:
I think mostly what you are doing here is causing code drift from the
upstream zic code. I don't think that's a very good idea, since we
do need to be able to track and apply bug fixes from them from time
to time ...
This patch makes various cosmetic improvements to the timezone code:
remove the use of the register qualifier, make some function declaration
syntax a bit more consistent, etc.
I'll apply this later today, barring any objections.
-Neil
Index: src/timezone/ialloc.c
