Fabien COELHO <[EMAIL PROTECTED]> writes:
> I'll keep that in mind. However, from other projects I've worked on, I
> found that large regression tests are not wasted.
> Maybe two level of tests wouldn't be bad, as when you're about to release
> a new version, it's better to pass large tests, but w
Dear Tom,
On Sat, 13 Mar 2004, Tom Lane wrote:
>
> I have reviewed and applied this, with some tweaking. I attach the
> patch as applied. Some comments on the changes:
>
> * You were careless about updating the comments to match the code.
> This is an essential activity to keep things intelli
Bruce Momjian <[EMAIL PROTECTED]> writes:
> Tom Lane wrote:
>> * I changed the message wording to conform to the message style
>> guidelines. I also made it complain about "costly sequential scans"
>> instead of "costly cross-type conversion", since ISTM that's what's
>> really at issue here. I'm
Tom Lane wrote:
>
> * I changed the message wording to conform to the message style
> guidelines. I also made it complain about "costly sequential scans"
> instead of "costly cross-type conversion", since ISTM that's what's
> really at issue here. I'm not completely wedded to that wording
Applied by Tom. Thanks.
---
Fabien COELHO wrote:
>
> Dear patchers,
>
> Following the discussion about previous versions of this patch, please
> find attached a new patch candidate for warning about costly foreign key
> r
Fabien COELHO <[EMAIL PROTECTED]> writes:
> Following the discussion about previous versions of this patch, please
> find attached a new patch candidate for warning about costly foreign key
> referential integrity checks.
I have reviewed and applied this, with some tweaking. I attach the
patch as
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---
Fabien COELHO wrote:
>
> Dear patchers,
Dear patchers,
Following the discussion about previous versions of this patch, please
find attached a new patch candidate for warning about costly foreign key
referential integrity checks.
1/ it generates a WARNING
2/ it DETAILs the attributes and types
3/ some regression tests are also append
