Re: [PATCHES] domain constraints and UNKNOWN params

2006-01-13 Thread David Wheeler
On Jan 11, 2006, at 9:28 PM, Neil Conway wrote: Ah, right. Attached is a corrected patch. I can confirm that this patch does indeed fix the issue for me on 8.1.2. Thanks! David ---(end of broadcast)--- TIP 5: don't forget to increase your free

Re: [PATCHES] domain constraints and UNKNOWN params

2006-01-12 Thread Neil Conway
On Thu, 2006-01-12 at 00:28 -0500, Neil Conway wrote: > Ah, right. Attached is a corrected patch. Applied to HEAD, REL8_1_STABLE, REL8_0_STABLE, and REL7_4_STABLE. -Neil ---(end of broadcast)--- TIP 4: Have you searched our list archives?

Re: [PATCHES] domain constraints and UNKNOWN params

2006-01-11 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > On Wed, 2006-01-11 at 23:31 -0500, Tom Lane wrote: >> I wonder whether there is any reasonably simple way to audit the whole >> backend for missing domain processing... > I don't really see a way to > check the code that doesn't require a fair amount of ma

Re: [PATCHES] domain constraints and UNKNOWN params

2006-01-11 Thread Neil Conway
On Wed, 2006-01-11 at 23:31 -0500, Tom Lane wrote: > This is a good catch, but the patch's added check on targetTyptype is a > waste of code and cycles. coerce_to_domain is perfectly capable of > doing nothing when nothing is called for. Ah, right. Attached is a corrected patch. > I wonder wheth

Re: [PATCHES] domain constraints and UNKNOWN params

2006-01-11 Thread Tom Lane
Neil Conway <[EMAIL PROTECTED]> writes: > I've also attached a patch that should fix the issue -- coerce_type() > neglected to apply coerce_to_domain() to the type inferred for an > UNKNOWN Param. This is a good catch, but the patch's added check on targetTyptype is a waste of code and cycles. co

[PATCHES] domain constraints and UNKNOWN params

2006-01-11 Thread Neil Conway
David Wheeler reported the following bug: when a protocol-level prepared statement with a parameter of UNKNOWN type is used, any domain constraints that are associated with the inferred type of the parameter are not checked when the statement is executed. Attached is a script David sent me to repro