Re: [PATCHES] libpq.dll on win32

2004-10-15 Thread Bruce Momjian
Patch applied. Thanks. I fixed a few merge conflicts. --- Magnus Hagander wrote: *** src/interfaces/libpq/fe-secure.c 28 Sep 2004 00:06:02 -1.54 --- src/interfaces/libpq/fe-secure.c 11 Oct 2004 19:50:22

Re: [PATCHES] libpq.dll on win32

2004-10-12 Thread Dave Page
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Magnus Hagander Sent: 11 October 2004 21:05 To: pgsql-patches Subject: [PATCHES] libpq.dll on win32 * Adds required functions to libpqdll.def and libpqddll.def. This includes the functions

Re: [PATCHES] libpq.dll on win32

2004-10-12 Thread Dave Page
-Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Tom Lane Sent: 12 October 2004 01:38 To: Magnus Hagander Cc: pgsql-patches Subject: Re: [PATCHES] libpq.dll on win32 Also, I count 3 *.def files to be fixed, not two. (We really oughta

Re: [PATCHES] libpq.dll on win32

2004-10-12 Thread Reini Urban
Tom Lane schrieb: Also, I count 3 *.def files to be fixed, not two. (We really oughta figure a way to generate them all from a single list file... can we rely on sed(1) being available in all Windows build environments?) for cygwin: yes. the non-gcc builds would need the mingw or cygwin versions.

Re: [PATCHES] libpq.dll on win32

2004-10-12 Thread Magnus Hagander
*** src/interfaces/libpq/fe-secure.c 28 Sep 2004 00:06:02 - 1.54 --- src/interfaces/libpq/fe-secure.c 11 Oct 2004 19:50:22 - *** *** 1201,1206 --- 1201,1212 return NULL; return conn-ssl; } + #else + void * + PQgetssl(PGconn *conn) + { +

Re: [PATCHES] libpq.dll on win32

2004-10-12 Thread Magnus Hagander
The avaiable options to do it are just horrible. There is edlin, but it can't be used for anything serious. Or there is the wonderful concept of writing something in vbscript. But putting vbscript in there doesn't seem like a very good option. ActiveState Perl? It's very widely used.

Re: [PATCHES] libpq.dll on win32

2004-10-12 Thread Tom Lane
Andrew Dunstan [EMAIL PROTECTED] writes: Yes, but it's not in there by default. If we're going to require a third party tool to be installed, we'd probably be better off requiring a simple sed.exe which is a single binary instead of the whole perl package which is hundreds of files and many

[PATCHES] libpq.dll on win32

2004-10-11 Thread Magnus Hagander
This patch aims to correct the issues with libpq.dll exporting too much on win32. Contains the following changes: * Exports PQgetssl() even if SSL support is not compiled in. In this case, it always returns NULL. This is required so programs that expect SSL version of the library does not crash

Re: [PATCHES] libpq.dll on win32

2004-10-11 Thread Tom Lane
Magnus Hagander [EMAIL PROTECTED] writes: *** src/interfaces/libpq/fe-secure.c28 Sep 2004 00:06:02 - 1.54 --- src/interfaces/libpq/fe-secure.c11 Oct 2004 19:50:22 - *** *** 1201,1206 --- 1201,1212 return NULL; return conn-ssl; }