Re: [PATCHES] mingw configure failure detection

2004-05-28 Thread Bruce Momjian
OK, fixed. --- Andrew Dunstan wrote: > Bruce Momjian wrote: > > >Andrew Dunstan wrote: > > > > > >>following up our conversation last night, I have tested the following > >>with autoconf 2.57 and it apparently does the r

Re: [PATCHES] mingw configure failure detection

2004-05-28 Thread Andrew Dunstan
Bruce Momjian wrote: Andrew Dunstan wrote: following up our conversation last night, I have tested the following with autoconf 2.57 and it apparently does the right thing: # Links sometimes fail undetected on Mingw - # so here we detect it and warn the user case $host_os in mingw*) AC_CONFIG_C

Re: [PATCHES] mingw configure failure detection

2004-05-17 Thread Bruce Momjian
Andrew Dunstan wrote: > following up our conversation last night, I have tested the following > with autoconf 2.57 and it apparently does the right thing: > > # Links sometimes fail undetected on Mingw - > # so here we detect it and warn the user > case $host_os in mingw*) > AC_CONFIG_COMMANDS([d

Re: [PATCHES] mingw configure failure detection

2004-05-13 Thread Bruce Momjian
Andrew Dunstan wrote: > Peter Eisentraut wrote: > > >Andrew Dunstan wrote: > > > > > >>The patch as applied is totally broken - the tests have to be run by > >>config.status after it has actually tried to make the links, which is > >>why I used AC_CONFIG_COMMANDS. > >> > >> > > > >Additional

Re: [PATCHES] mingw configure failure detection

2004-05-13 Thread Andrew Dunstan
Peter Eisentraut wrote: Andrew Dunstan wrote: The patch as applied is totally broken - the tests have to be run by config.status after it has actually tried to make the links, which is why I used AC_CONFIG_COMMANDS. Additional note: Instead of listing the files explicitly, just use $CONFI

Re: [PATCHES] mingw configure failure detection

2004-05-13 Thread Peter Eisentraut
Andrew Dunstan wrote: > The patch as applied is totally broken - the tests have to be run by > config.status after it has actually tried to make the links, which is > why I used AC_CONFIG_COMMANDS. Additional note: Instead of listing the files explicitly, just use $CONFIG_LINKS, which contains th

Re: [PATCHES] mingw configure failure detection

2004-05-13 Thread Andrew Dunstan
The patch as applied is totally broken - the tests have to be run by config.status after it has actually tried to make the links, which is why I used AC_CONFIG_COMMANDS. cheers andrew Bruce Momjian wrote: Adjusted attached patch applied. Thanks. I didn't change 'test -e' because 'test -h' d

Re: [PATCHES] mingw configure failure detection

2004-05-12 Thread Bruce Momjian
Tom Lane wrote: > Peter Eisentraut <[EMAIL PROTECTED]> writes: > > Am Montag, 10. Mai 2004 09:17 schrieb Andrew Dunstan: > >> It appears that Dann Corbit has filed a MinGW bug on this, with accurate > >> problem description, but he received a less than stellar response. See > >> > >> https://sourc

Re: [PATCHES] mingw configure failure detection

2004-05-12 Thread Bruce Momjian
Adjusted attached patch applied. Thanks. I didn't change 'test -e' because 'test -h' doesn't work (is symlink test on my platform). test -f actually works on symlinks too in MinGW, strangely enough. Anyway, the code is only run on MinGW so we don't have to worry about other platforms. I added

Re: [PATCHES] mingw configure failure detection

2004-05-12 Thread Tom Lane
Peter Eisentraut <[EMAIL PROTECTED]> writes: > Am Montag, 10. Mai 2004 09:17 schrieb Andrew Dunstan: >> It appears that Dann Corbit has filed a MinGW bug on this, with accurate >> problem description, but he received a less than stellar response. See >> >> https://sourceforge.net/tracker/index.php

Re: [PATCHES] mingw configure failure detection

2004-05-12 Thread Peter Eisentraut
Am Montag, 10. Mai 2004 09:17 schrieb Andrew Dunstan: > It appears that Dann Corbit has filed a MinGW bug on this, with accurate > problem description, but he received a less than stellar response. See > > https://sourceforge.net/tracker/index.php? > func=detail&aid=931263&group_id=2435&atid=102435

Re: [PATCHES] mingw configure failure detection

2004-05-10 Thread Bruce Momjian
Andrew Dunstan wrote: > I said: > > Peter Eisentraut said: > >> Andrew Dunstan wrote: > >>> This patch for configure.in detects the link failures in MINGW that I > >>> and others have seen and warns the user they have to fix it up. > >> > >> I continue to object to these sort of patches if no one w

Re: [PATCHES] mingw configure failure detection

2004-05-10 Thread Andrew Dunstan
I said: > Peter Eisentraut said: >> Andrew Dunstan wrote: >>> This patch for configure.in detects the link failures in MINGW that I >>> and others have seen and warns the user they have to fix it up. >> >> I continue to object to these sort of patches if no one wants to >> bother >> to contact the

Re: [PATCHES] mingw configure failure detection

2004-05-09 Thread Andrew Dunstan
Peter Eisentraut said: > Andrew Dunstan wrote: >> This patch for configure.in detects the link failures in MINGW that I >> and others have seen and warns the user they have to fix it up. > > I continue to object to these sort of patches if no one wants to bother > to contact the mingw maintainers

Re: [PATCHES] mingw configure failure detection

2004-05-09 Thread Peter Eisentraut
Andrew Dunstan wrote: > This patch for configure.in detects the link failures in MINGW that I > and others have seen and warns the user they have to fix it up. I continue to object to these sort of patches if no one wants to bother to contact the mingw maintainers about this problem. Maybe they

Re: [PATCHES] mingw configure failure detection

2004-05-08 Thread Bruce Momjian
I have added to the Win32 TODO to remove this when we find the real cause for the link failures. Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches I will try to apply it within the next 48 hours. -

[PATCHES] mingw configure failure detection

2004-05-08 Thread Andrew Dunstan
Bruce Momjian wrote: Andrew Dunstan wrote: It's different because we know why we need that one: we understand the cause of the behavior and we therefore can have some confidence that the kluge will fix it (or not, as the case may be). I have zero confidence in looping five times around an "l