This patch was withdrawn by the author.
---
Neil Conway wrote:
> Tom Lane <[EMAIL PROTECTED]> writes:
> > That would be okay with me. It might be a good idea to change the
> > name completely (perhaps CopyTupleDesc() ?) as
Your patch has been added to the PostgreSQL unapplied patches list at:
http://momjian.postgresql.org/cgi-bin/pgpatches
I will try to apply it within the next 48 hours.
---
Neil Conway wrote:
> Tom Lane <[EMAIL PRO
Tom Lane <[EMAIL PROTECTED]> writes:
> That would be okay with me. It might be a good idea to change the
> name completely (perhaps CopyTupleDesc() ?) as a means of catching
> places that aren't correctly updated.
Done, and done -- a revised patch is attached.
-Neil
Index: src/backend/access/co
Neil Conway <[EMAIL PROTECTED]> writes:
> Now that I think about
> it, we could also just change the API to remove
> CreateTupleDescCopyConstr(), and replace it with an additional bool
> parameter to CreateTupleDescCopy().
That would be okay with me. It might be a good idea to change the name
com
Tom Lane <[EMAIL PROTECTED]> writes:
> I think this is taking the "avoid duplicated code" mantra a little
> far. You've defined a subroutine that returns a TupleDesc that is
> internally inconsistent and cannot usefully be used for anything
> until it's fixed by the parent routines.
Fair enough.
Neil Conway <[EMAIL PROTECTED]> writes:
> This patch refactors CreateTupleDescCopy() and
> CreateTupleDescCopyConstr() to remove some duplicated code, and clean
> things up a little bit.
I think this is taking the "avoid duplicated code" mantra a little far.
You've defined a subroutine that return
This patch refactors CreateTupleDescCopy() and
CreateTupleDescCopyConstr() to remove some duplicated code, and clean
things up a little bit.
-Neil
Index: src/backend/access/common/tupdesc.c
===
RCS file: /var/lib/cvs/pgsql-server/src/
