Re: [PATCHES] simply custom variables protection

2007-04-07 Thread Bruce Momjian
Patch rejected; please continue discussion and resubmit. --- Pavel Stehule wrote: > Hello > > this patch contains function ArmorCustomVariables. This function set flag > armored on any custom variable. From this moment on

Re: [PATCHES] simply custom variables protection

2007-04-07 Thread Tom Lane
"Pavel Stehule" <[EMAIL PROTECTED]> writes: >> How does a user protect a custom variable using your code? I don't see >> any API that would allow that. > Every module is responsibile for protectiong own custom variables. Only > module knows if some variable needs protection. And after module >

Re: [PATCHES] simply custom variables protection

2007-04-07 Thread Pavel Stehule
Furthermore I believe the patch is incomplete/wrong, because it adds only one check on the "armored" flag, whereas PGC_SUSET affects behavior in a number of places. I also notice that it will make setting of a an armored custom variable from postgresql.conf fail outright in non-superuser session

Re: [PATCHES] simply custom variables protection

2007-04-07 Thread Pavel Stehule
CC: pgsql-patches@postgresql.org, [EMAIL PROTECTED], [EMAIL PROTECTED] > >Subject: Re: [PATCHES] simply custom variables protection > >Date: Sat, 7 Apr 2007 11:54:13 -0400 (EDT) > > > > > >Pavel, would you remind me how this is useful? > > > >--

Re: [PATCHES] simply custom variables protection

2007-04-07 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Pavel Stehule wrote: >> My patch allows to allert somebody so any custom variable is protected. > How does a user protect a custom variable using your code? I don't see > any API that would allow that. The call would have to come from the loadable libr

Re: [PATCHES] simply custom variables protection

2007-04-07 Thread Bruce Momjian
m: Bruce Momjian <[EMAIL PROTECTED]> > >To: Pavel Stehule <[EMAIL PROTECTED]> > >CC: pgsql-patches@postgresql.org, [EMAIL PROTECTED], [EMAIL PROTECTED] > >Subject: Re: [PATCHES] simply custom variables protection > >Date: Sat, 7 A

Re: [PATCHES] simply custom variables protection

2007-04-07 Thread Pavel Stehule
value. Regards Pavel Stehule From: Bruce Momjian <[EMAIL PROTECTED]> To: Pavel Stehule <[EMAIL PROTECTED]> CC: pgsql-patches@postgresql.org, [EMAIL PROTECTED], [EMAIL PROTECTED] Subject: Re: [PATCHES] simply custom variables protection Date: Sat, 7 Apr 2007 11:54:13 -0400 (EDT) Pavel, wo

Re: [PATCHES] simply custom variables protection

2007-04-07 Thread Bruce Momjian
Andrew Dunstan wrote: > Bruce Momjian wrote: > > Pavel, would you remind me how this is useful? > > > > --- > > > > Pavel Stehule wrote: > > > >> Hello > >> > >> this patch contains function ArmorCustomVariables. This functi

Re: [PATCHES] simply custom variables protection

2007-04-07 Thread Andrew Dunstan
Bruce Momjian wrote: Pavel, would you remind me how this is useful? --- Pavel Stehule wrote: Hello this patch contains function ArmorCustomVariables. This function set flag armored on any custom variable. From this mo

Re: [PATCHES] simply custom variables protection

2007-04-07 Thread Bruce Momjian
Pavel, would you remind me how this is useful? --- Pavel Stehule wrote: > Hello > > this patch contains function ArmorCustomVariables. This function set flag > armored on any custom variable. From this moment only superuse

Re: [PATCHES] simply custom variables protection

2007-03-22 Thread Bruce Momjian
Patch removed from patch queue. --- Pavel Stehule wrote: > > >"Pavel Stehule" <[EMAIL PROTECTED]> writes: > > > this patch contains function ArmorCustomVariables. This function set > >flag > > > armored on any custom varia

Re: [PATCHES] simply custom variables protection

2007-03-22 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > Your patch has been added to the PostgreSQL unapplied patches list at: > > http://momjian.postgresql.org/cgi-bin/pgpatches > > It will be applied as soon as one of the PostgreSQL committers reviews > > and approves it. > > This pa

Re: [PATCHES] simply custom variables protection

2007-03-22 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > Your patch has been added to the PostgreSQL unapplied patches list at: > http://momjian.postgresql.org/cgi-bin/pgpatches > It will be applied as soon as one of the PostgreSQL committers reviews > and approves it. This patch was already objected to,

Re: [PATCHES] simply custom variables protection

2007-03-22 Thread Bruce Momjian
Your patch has been added to the PostgreSQL unapplied patches list at: http://momjian.postgresql.org/cgi-bin/pgpatches It will be applied as soon as one of the PostgreSQL committers reviews and approves it. --- Pa

Re: [PATCHES] simply custom variables protection

2007-03-10 Thread Pavel Stehule
"Pavel Stehule" <[EMAIL PROTECTED]> writes: > this patch contains function ArmorCustomVariables. This function set flag > armored on any custom variable. From this moment only superuser can change > this variable. Why is this a good idea? Why don't you just fix the problem as previously agr

Re: [PATCHES] simply custom variables protection

2007-03-10 Thread Tom Lane
"Pavel Stehule" <[EMAIL PROTECTED]> writes: > this patch contains function ArmorCustomVariables. This function set flag > armored on any custom variable. From this moment only superuser can change > this variable. Why is this a good idea? Why don't you just fix the problem as previously agreed,

[PATCHES] simply custom variables protection

2007-03-10 Thread Pavel Stehule
Hello this patch contains function ArmorCustomVariables. This function set flag armored on any custom variable. From this moment only superuser can change this variable. p.s. use it together with ResetPGVariable() Regards Pavel Stehule ___