Re: [PATCHES] small smgr refactoring

2004-01-19 Thread Alvaro Herrera
On Mon, Jan 19, 2004 at 06:20:21PM -0500, Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > (Well, it changes an ad-hoc linked > > list into a proper List). > > Why? AFAICT that just makes the code bigger, uglier, and slower ... Oh, does it? Hmm. When I originally wrote this, it

Re: [PATCHES] small smgr refactoring

2004-01-19 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > (Well, it changes an ad-hoc linked > list into a proper List). Why? AFAICT that just makes the code bigger, uglier, and slower ... I am pretty dubious of PendingDeletesBeginXact, too, and of moving this list out of TopMemoryContext. Please justify.

[PATCHES] small smgr refactoring

2004-01-19 Thread Alvaro Herrera
I attach a small patch that slightly refactors some code in storage/smgr/smgr.c. Regression test pass. There's no change in functionality, only code reordering. (Well, it changes an ad-hoc linked list into a proper List). Please review and if Ok, apply. -- Alvaro Herrera () "At least to kerne