OK, I have applied the following patch to fix the Cygwin _timezone
issue. I moved the TIMEZONE_GLOBAL up into port.h and change pgtz.c to
use that instead. I also changed the configure test for INT_TIMEZONE to
test for _timezone on Cygwin. This should fix all those problems.
You found a few
I have done the same cleanup for _tzname for clarity and because some
files were using tzname as local variable names (pgtz.c).
---
Bruce Momjian wrote:
OK, I have applied the following patch to fix the Cygwin _timezone
Bruce Momjian schrieb:
Reini Urban wrote:
# PGAC_VAR_INT_TIMEZONE
# -
# Check if the global variable `timezone' exists. If so, define
# HAVE_INT_TIMEZONE.
AC_DEFUN([PGAC_VAR_INT_TIMEZONE],
[AC_CACHE_CHECK(for int timezone,
Bruce Momjian schrieb:
Tom Lane wrote:
Reini Urban [EMAIL PROTECTED] writes:
Yes, they are talking about the localtime return value,
but nevertheless the newlib folks refer to that. Their fault.
Should I discuss that with them?
Probably. They have a gratuitous variation from the Single Unix
Reini Urban [EMAIL PROTECTED] writes:
This test fails, because you cannot do arithmetic with time_t.
You apparently speak some different flavor of C than the rest of us.
regards, tom lane
---(end of broadcast)---
TIP 4:
Reini Urban wrote:
# PGAC_VAR_INT_TIMEZONE
# -
# Check if the global variable `timezone' exists. If so, define
# HAVE_INT_TIMEZONE.
AC_DEFUN([PGAC_VAR_INT_TIMEZONE],
[AC_CACHE_CHECK(for int timezone, pgac_cv_var_int_timezone,
Tom Lane schrieb:
Reini Urban [EMAIL PROTECTED] writes:
Added configure time_t timezone check for the SUSV definition.
Kindly do not claim that this is per SUS spec.
http://www.opengroup.org/onlinepubs/007908799/xsh/timezone.html
oops! sorry :(
--
Reini Urban
I am inclined to leave the #ifdef Cygwin test in the code rather than
add a configure check.
---
Reini Urban wrote:
Tom Lane schrieb:
Reini Urban [EMAIL PROTECTED] writes:
Added configure time_t timezone check for the
Bruce Momjian schrieb:
I am inclined to leave the #ifdef Cygwin test in the code rather than
add a configure check.
No,
There are a lot of other systems with time_t timezone!
newlib explains it like this:
/* defines for the opengroup specifications Derived from Issue 1 of the
SVID. */
extern
Reini Urban [EMAIL PROTECTED] writes:
But the time_t timezone issue is here:
XSHd7 Aardvark Change Request Report
http://www.opengroup.org/austin/docs/austin_97.txt
(ERN 20 Accept as marked, page 1177)
There is nothing whatever on that page about the datatype of the
timezone variable.
Tom Lane schrieb:
Reini Urban [EMAIL PROTECTED] writes:
But the time_t timezone issue is here:
XSHd7 Aardvark Change Request Report
http://www.opengroup.org/austin/docs/austin_97.txt
(ERN 20 Accept as marked, page 1177)
There is nothing whatever on that page about the datatype of the
timezone
Reini Urban [EMAIL PROTECTED] writes:
Yes, they are talking about the localtime return value,
but nevertheless the newlib folks refer to that. Their fault.
Should I discuss that with them?
Probably. They have a gratuitous variation from the Single Unix Spec.
But what may be more to the
Tom Lane schrieb:
Reini Urban [EMAIL PROTECTED] writes:
Yes, they are talking about the localtime return value,
but nevertheless the newlib folks refer to that. Their fault.
Should I discuss that with them?
Probably. They have a gratuitous variation from the Single Unix Spec.
But what may be
Tom Lane wrote:
Reini Urban [EMAIL PROTECTED] writes:
Yes, they are talking about the localtime return value,
but nevertheless the newlib folks refer to that. Their fault.
Should I discuss that with them?
Probably. They have a gratuitous variation from the Single Unix Spec.
But
Now I've found time to test beta2 and came up
with the attached better patch:
Added configure time_t timezone check for the SUSV definition.
Not only cygwin, all newlib installations without struct tm timezone.
Casted to (int) timezone.
(configure should really be re-created by autoconf. I patched
Reini Urban [EMAIL PROTECTED] writes:
Added configure time_t timezone check for the SUSV definition.
Kindly do not claim that this is per SUS spec.
http://www.opengroup.org/onlinepubs/007908799/xsh/timezone.html
regards, tom lane
---(end of
16 matches
Mail list logo