On Wed, 2007-01-31 at 12:14 -0500, Tom Lane wrote:
> Is anything happening with that? This code fails regression on my
> primary development machine, and my annoyance level is rising rapidly.
> I'll probably remove the uuid test from the schedule files as a
> band-aid, if no fix is forthcoming soo
Neil Conway <[EMAIL PROTECTED]> writes:
> On Sun, 2007-01-28 at 13:08 -0500, Kris Jurka wrote:
>> This fails on Solaris 9 buildfarm members kudu and dragonfly because they
>> do not support the "hh" scanf modifier using in UUID_FMTx.
> Hmmm. I suppose the easiest thing to do would be to rewrite t
On Sun, 2007-01-28 at 13:08 -0500, Kris Jurka wrote:
> This fails on Solaris 9 buildfarm members kudu and dragonfly because they
> do not support the "hh" scanf modifier using in UUID_FMTx.
Hmmm. I suppose the easiest thing to do would be to rewrite the uuid
parsing function to not depend on ssca
On Sat, 27 Jan 2007, Neil Conway wrote:
On Fri, 2007-01-26 at 13:11 +0100, Gevik Babakhani wrote:
As commented by Peter, I have done some re-styling.
Some additional tests and format checking have been added to this patch.
Barring any objections, I'll apply a revised version of this patch
t
Gevik Babakhani <[EMAIL PROTECTED]> writes:
> Is the following OK?
>
> * IDENTIFICATION
> * $PostgreSQL$
Yeah, that's the appropriate starting point --- CVS will take it from there.
>> Please drop the conversions to/from varchar; text is sufficient.
> Do you also mean to also remove t
Neil Conway <[EMAIL PROTECTED]> writes:
> I think the copyright header on completely new code should just include
> the current year, shouldn't it? I've just marked both files as
> "Copyright (c) 2007 [PGDG]".
I've always made a habit of using the full copyright notice including
the UC Berkeley li
On Sat, 2007-01-27 at 23:53 -0500, Tom Lane wrote:
> A few comments after a quick once-over, perhaps you caught all this
> already...
Much of it :) But thanks for the review.
> uuid.c header is missing $PostgreSQL$ line, so is uuid.h,
> copyright notice in the latter seems wrong too.
I think the
> uuid.c header is missing $PostgreSQL$ line, so is uuid.h,
> copyright notice in the latter seems wrong too.
I left this part because it is not clear to me what to put there.
Is the following OK?
* IDENTIFICATION
* $PostgreSQL$
*
*-
Neil Conway <[EMAIL PROTECTED]> writes:
> Barring any objections, I'll apply a revised version of this patch
> tomorrow. We need some more work on the uuid feature (e.g. generator
> functions and documentation), but that can be done shortly.
A few comments after a quick once-over, perhaps you caug
Neil Conway wrote:
> On Fri, 2007-01-26 at 13:11 +0100, Gevik Babakhani wrote:
> > As commented by Peter, I have done some re-styling.
> > Some additional tests and format checking have been added to this patch.
>
> Barring any objections, I'll apply a revised version of this patch
> tomorrow. We
On Fri, 2007-01-26 at 13:11 +0100, Gevik Babakhani wrote:
> As commented by Peter, I have done some re-styling.
> Some additional tests and format checking have been added to this patch.
Barring any objections, I'll apply a revised version of this patch
tomorrow. We need some more work on the uuid
Folks,
As commented by Peter, I have done some re-styling.
Some additional tests and format checking have been added to this patch.
> Put your file at the end of the OBJS variable (or in some sort of
> sensible order).
Done.
>
> Put your file at the end of the tests (or in some sort of sensib
12 matches
Mail list logo
