Re: [PATCHES] DROP OWNED BY doesn't work

2006-08-20 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Sounds a pretty obvious move. This would be it then. Please note the > changes to the ObjectAddresses stuff, mainly to not move the definition > of struct ObjectAddresses to dependency.h but instead move only the > typedef. Looks pretty reasonable, ex

Re: [PATCHES] DROP OWNED BY doesn't work

2006-08-20 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera <[EMAIL PROTECTED]> writes: > > Ok, this patch implements more or less this idea; except that instead of > > checking the list of implicit dependencies for later objects, we iterate > > twice on the list of objects to delete, and create a list of implicit > > depend

Re: [PATCHES] DROP OWNED BY doesn't work

2006-08-20 Thread Tom Lane
Alvaro Herrera <[EMAIL PROTECTED]> writes: > Ok, this patch implements more or less this idea; except that instead of > checking the list of implicit dependencies for later objects, we iterate > twice on the list of objects to delete, and create a list of implicit > dependencies on all of them the

Re: [PATCHES] DROP OWNED BY doesn't work

2006-08-19 Thread Alvaro Herrera
Tom Lane wrote: > What I was thinking of was > > find all target objects using pg_shdepend, make an > ObjectAddresses list of them > > for (each item of list) > { > if (already deleted) > continue; > if (implicit d