Tom Lane wrote:
Bruce Momjian <[EMAIL PROTECTED]> writes:
It passes all the regression tests. I have also included a diff against
Andrew's version so you can see my changes. It seems Andrew had a very
current version of initdb. The only update he missed was the change to
test the number of
Bruce Momjian wrote:
It passes all the regression tests. I have also included a diff against
Andrew's version so you can see my changes. It seems Andrew had a very
current version of initdb. The only update he missed was the change to
test the number of connections before shared buffers --- I
Repost:
On Tue, 4 Nov 2003, Kris Jurka wrote:
>
> in psql \h alter schema does not produce the desired help because the sgml
> doc has the incorrect tag so it does not get picked up by
> the create_help.pl script.
>
> Kris Jurka
>
Index: doc/src/sgml/ref/alter_schema.sgml
==
Kris Jurka writes:
> > in psql \h alter schema does not produce the desired help because the sgml
> > doc has the incorrect tag so it does not get picked up by
> > the create_help.pl script.
Thanks for the reminder. Patch installed.
--
Peter Eisentraut [EMAIL PROTECTED]
--
Bruce Momjian wrote:
Here is a slightly modified version of Andrew's great work in making a C
version of initdb. Other than minor cleanups, the only big change was
to remove rmdir handling because we using rm -r and rmdir /s in
commands/dbcommands.c, so we might as use the same thing for initdb
Andrew Dunstan wrote:
>
>
> Tom Lane wrote:
>
> >Bruce Momjian <[EMAIL PROTECTED]> writes:
> >
> >
> >>It passes all the regression tests. I have also included a diff against
> >>Andrew's version so you can see my changes. It seems Andrew had a very
> >>current version of initdb. The only u
Bruce Momjian wrote:
Yes, I was concerned too that everything was in there. I checked the
initdb.sh logs and found that the only thing not added was the checking
of the max number of connections before checking the max number of
buffers, which I added. The other stuff was in there. I also che
Andrew Dunstan wrote:
>
>
> Bruce Momjian wrote:
>
> >Here is a slightly modified version of Andrew's great work in making a C
> >version of initdb. Other than minor cleanups, the only big change was
> >to remove rmdir handling because we using rm -r and rmdir /s in
> >commands/dbcommands.c, so
Andrew Dunstan wrote:
>
>
> Bruce Momjian wrote:
>
> >Yes, I was concerned too that everything was in there. I checked the
> >initdb.sh logs and found that the only thing not added was the checking
> >of the max number of connections before checking the max number of
> >buffers, which I added.
Thanks, I was just getting to this today, but Peter has applied it.
Thanks.
---
Kris Jurka wrote:
>
> Repost:
>
> On Tue, 4 Nov 2003, Kris Jurka wrote:
>
> >
> > in psql \h alter schema does not produce the desired help
Andrew Dunstan writes:
> recreating the datadir if we didn't create it initially should be OK in
> that case, and it makes the code simpler.
That should be avoided, because you'll have trouble recreating the
original directory with all its properties such as ownership, permissions,
etc., at least
Bruce Momjian wrote:
Andrew Dunstan wrote:
My comments:
I have no problem with shelling out to rmdir - although my goal was to
avoid shelling out to anything other than postgres itself. I think
recreating the datadir if we didn't create it initially should be OK in
that case, and it
Peter Eisentraut <[EMAIL PROTECTED]> writes:
> Andrew Dunstan writes:
>> recreating the datadir if we didn't create it initially should be OK in
>> that case, and it makes the code simpler.
> That should be avoided, because you'll have trouble recreating the
> original directory with all its prope
A general re-organization of Alter Table. Node wise, it is a
AlterTableStmt with a list of AlterTableCmds. The Cmds are the
individual actions to be completed (Add constraint, drop constraint, add
column, etc.)
Processing is done in 2 phases. The first phase updates the system
catalogs and create
Tom Lane wrote:
> Peter Eisentraut <[EMAIL PROTECTED]> writes:
> > Andrew Dunstan writes:
> >> recreating the datadir if we didn't create it initially should be OK in
> >> that case, and it makes the code simpler.
>
> > That should be avoided, because you'll have trouble recreating the
> > origina
Peter Eisentraut wrote:
> Andrew Dunstan writes:
>
> > recreating the datadir if we didn't create it initially should be OK in
> > that case, and it makes the code simpler.
>
> That should be avoided, because you'll have trouble recreating the
> original directory with all its properties such as
Bruce Momjian <[EMAIL PROTECTED]> writes:
>> Consider also the strong likelihood that the data directory's parent
>> directory is owned by root,
> Again, this directory recreate happens only on Win32, an I thought it
> would be OK there.
Windows has no concept of directory permissions at all? I
Bruce Momjian <[EMAIL PROTECTED]> writes:
> Recreating the directory only happens on WIN32, where rmdir doesn't
> allow you to only delete files and subdirectories and not the parent
> directory. Non-Win32 does rm -rf dir/*.
I think we should forget about invoking rm as a subprocess at all, and
j
Tom Lane wrote:
> Bruce Momjian <[EMAIL PROTECTED]> writes:
> >> Consider also the strong likelihood that the data directory's parent
> >> directory is owned by root,
>
> > Again, this directory recreate happens only on Win32, an I thought it
> > would be OK there.
>
> Windows has no concept of d
Tom Lane wrote:
> Bruce Momjian <[EMAIL PROTECTED]> writes:
> > Recreating the directory only happens on WIN32, where rmdir doesn't
> > allow you to only delete files and subdirectories and not the parent
> > directory. Non-Win32 does rm -rf dir/*.
>
> I think we should forget about invoking rm a
Andrew Dunstan wrote:
> >Good. I can do rmdir() in C in port/dirmod.c if we need it. Right now
> >we are doing system(rm/rmdir) in dbcommands.c so we should consistent.
> >Let's stay with system(rm/rmdir) and if it doesn't work as we expect, we
> >can add your rmdir() code and put it in port/dirm
Also, I see this at the top of the code:
* author: Andrew Dunstan mailto:[EMAIL PROTECTED]
*
* Copyright (C) 2003 Andrew Dunstan
* Portions Copyright (c) 1996-2003, PostgreSQL Global Development Group
* Portions Copyright (c) 1994, Regents of t
Tom Lane wrote:
Bruce Momjian <[EMAIL PROTECTED]> writes:
Consider also the strong likelihood that the data directory's parent
directory is owned by root,
Again, this directory recreate happens only on Win32, an I thought it
would be OK there.
Windows has no concept of director
Bruce Momjian wrote:
Also, I see this at the top of the code:
* author: Andrew Dunstan mailto:[EMAIL PROTECTED]
*
* Copyright (C) 2003 Andrew Dunstan
* Portions Copyright (c) 1996-2003, PostgreSQL Global Development Group
* Portions Copyrigh
Bruce Momjian wrote:
I ran some tests using XP "CMD" and found:
"C:\test"
and
"\test"
works but:
"test"
does not work. Since I see that the output always has a leading path,
On Windows, pgpath is guaranteed to be a full path (see call to
expanded_path() ) exactly so it w
Andrew Dunstan wrote:
The problem with this is that you now have 2 quoted strings.
I take this back. You *can* have multiple quoted strings on the command
line - it just doesn't work in popen() because it uses the /C flag.
Sorry for my confusion.
cheers
andrew
-
Andrew Dunstan wrote:
>
>
> Andrew Dunstan wrote:
>
> >
> >
> >
> > The problem with this is that you now have 2 quoted strings.
>
>
> I take this back. You *can* have multiple quoted strings on the command
> line - it just doesn't work in popen() because it uses the /C flag.
Oh, OK, that's
Neil Conway <[EMAIL PROTECTED]> writes:
> Interesting. I've heard in some shops it is standard policy to order
> the fields in all structs by their descending sizes (making allowances
> for platform-specific variations), so as to reduce padding. Do you
> think it would be worthwhile to systematical
ljb <[EMAIL PROTECTED]> writes:
> Here's the patch to restore libpgtcl compatibility with Tcl-8.0, which was
> lost in 7.4RC1 with my other patch to fix corrupt binary large-object reads
> and writes. This patch is against PostgreSQL-7.4RC1.
Applied. Many thanks for double-checking it.
We are no longer using the WIN32_DEV CVS branch. We are doing all Win32
work in HEAD now. I have already moved any WIN32_DEV changes up into
HEAD. I have updated the Win32 web page to indicate this:
http://momjian.postgresql.org/main/writings/pgsql/win32.html
Marc, would you remove the
Attatched is the latest version of my patch that makes the
signal(SIG_PIPE, SIG_IGN) calls around the send() syscall conditional:
they are not sufficient to ensure that multithreaded libpq users are not
killed by SIGPIPE signals, and they cause a noticable slowdown.
I've switched to a global fla
removed, and files from ftp have also been removed ...
On Sat, 8 Nov 2003, Bruce Momjian wrote:
> We are no longer using the WIN32_DEV CVS branch. We are doing all Win32
> work in HEAD now. I have already moved any WIN32_DEV changes up into
> HEAD. I have updated the Win32 web page to indicate
Gaetano Mendola wrote:
> Hi all,
> why START TRANSACTION READ ONLY is allowed
> and not BEGIN READ ONLY ?
Seems it should be allowed so that BEGIN and START TRANSACTION behave
the same.
In fact, the BEGIN manual page says:
has the same functionality
as BEGIN.
which is currently not true
Yes, I have reverted the lines outlined below and am attaching the
patch.
---
Gaetano Mendola wrote:
> Gaetano Mendola wrote:
>
> >
> >
> >
> > ---
Patch applied to 7.4 and HEAD. Thanks.
---
Christopher Kings-Lynne wrote:
> I have attached a more comprehensive MSWIN FAQ patch. Basically, the
> instructions were way out of date and incorrect. Installing Postgres
>
35 matches
Mail list logo
