Re: [PATCHES] [PATCH] s_lock support for win32

2004-07-01 Thread Claudio Natoli
> The win32 port doesn't have a native user space spinlock > implementation yet. It does when compiled with MingW. Cheers, Claudio --- Certain disclaimers and policies apply to all email sent from Memetrics. For the full text of these disclaimers and policies see http://www.memetrics.com/e

Re: [PATCHES] PITR Archive Recovery

2004-07-01 Thread ohp
Many thanks for your reply Simon On Wed, 30 Jun 2004, Simon Riggs wrote: > Date: Wed, 30 Jun 2004 19:29:14 +0100 > From: Simon Riggs <[EMAIL PROTECTED]> > To: [EMAIL PROTECTED] > Cc: [EMAIL PROTECTED] > Subject: Re: [PATCHES] PITR Archive Recovery > > On Wed, 2004-06-30 at 12:27, [EMAIL PROTECTED]

Re: [PATCHES] [PATCH] s_lock support for win32

2004-07-01 Thread Tom Lane
Claudio Natoli <[EMAIL PROTECTED]> writes: >> The win32 port doesn't have a native user space spinlock >> implementation yet. > It does when compiled with MingW. Are we intending to support any other compilers/build environments than that one? Offhand I would prefer to see us using the existing

Re: [PATCHES] latest plperl

2004-07-01 Thread Andrew Dunstan
Joe Conway said: > Andrew Dunstan wrote: >> The attached patch (and 2 new files incorporating previous >> eloglvl.[ch] as before) has the following changes over previously >> sent patch >> (fixes all by me): > > Some comments below: > > > In plperl_trigger_build_args(), this l

Re: [Plperlng-devel] Re: [PATCHES] latest plperl

2004-07-01 Thread Andrew Dunstan
I also got the rpath test sense wrong in the make file fix. It should read (assuming this mailer dowsn't break lines badly): ifeq ($(enable_rpath), yes) SHLIB_LINK = $(perl_embed_ldflags) $(BE_DLLLIBS) -Wl,-rpath,$(perl_archlibexp)/CORE else SHLIB_LINK = $(perl_embed_ldflags) $(BE_DLLLIBS) endif

Re: [Plperlng-devel] Re: [PATCHES] latest plperl

2004-07-01 Thread Joe Conway
Andrew Dunstan wrote: I also got the rpath test sense wrong in the make file fix. It should read (assuming this mailer dowsn't break lines badly): ifeq ($(enable_rpath), yes) SHLIB_LINK = $(perl_embed_ldflags) $(BE_DLLLIBS) -Wl,-rpath,$(perl_archlibexp)/CORE else SHLIB_LINK = $(perl_embed_ldflags)

Re: [PATCHES] latest plperl

2004-07-01 Thread Joe Conway
Andrew Dunstan wrote: I will do some checking on these changes, but with those caveats they look good to me. Attached is an all inclusive revised patch. Please review and comment. If there are no objections, I'll commit in a few hours. As a side note, I think it would be *really* helpful if there

Re: [PATCHES] latest plperl

2004-07-01 Thread Joe Conway
Andrew Dunstan wrote: Doh! Very bogus! sizeof(int)and a malloc to boot ??? I didn't check the trigger code much because it has supposedly been working for quite a while. I will examine more closely. Well, essentially 4 bytes (sizeof(int)) were being allocated to print a two byte interger that can

Re: [PATCHES] latest plperl

2004-07-01 Thread Tom Lane
Joe Conway <[EMAIL PROTECTED]> writes: > As a side note, I think it would be *really* helpful if there were a > more comprehensive test script, and an expected results file available. > Not sure though if it could be included in the standard regression tests > on a configure-conditional basis --

Re: [PATCHES] latest plperl

2004-07-01 Thread Andrew Dunstan
Joe Conway said: > > As a side note, I think it would be *really* helpful if there were a > more comprehensive test script, and an expected results file available. > Not sure though if it could be included in the standard regression > tests on a configure-conditional basis -- anyone know? To the

Re: [PATCHES] pg_tablespace_databases

2004-07-01 Thread Andreas Pflug
Joe Conway wrote: If there are no objections, I'll review and apply this tonight (west coast USA time). Andreas, please provide a corresponding documentation patch. Here we are. Since I don't have a SGML build environment, syntax is not checked. Regards, Andreas Index: func.sgml =

Re: [PATCHES] latest plperl

2004-07-01 Thread Andrew Dunstan
Alvaro Herrera said: > On Thu, Jul 01, 2004 at 09:33:57AM -0700, Joe Conway wrote: > >> As a side note, I think it would be *really* helpful if there were a >> more comprehensive test script, and an expected results file >> available. Not sure though if it could be included in the standard >> regr

Re: [PATCHES] latest plperl

2004-07-01 Thread Alvaro Herrera
On Thu, Jul 01, 2004 at 09:33:57AM -0700, Joe Conway wrote: > As a side note, I think it would be *really* helpful if there were a > more comprehensive test script, and an expected results file available. > Not sure though if it could be included in the standard regression tests > on a configur

Re: [PATCHES] pg_tablespace_databases

2004-07-01 Thread Joe Conway
Andreas Pflug wrote: From an idea of Bruce, the attached patch implements the function pg_tablespace_databases(oid) RETURNS SETOF oid which delivers as set of database oids having objects in the selected tablespace, enabling an admin to examine only the databases affecting the tablespace for obje

Re: [PATCHES] latest plperl

2004-07-01 Thread Joe Conway
Andrew Dunstan wrote: Joe Conway said: As a side note, I think it would be *really* helpful if there were a more comprehensive test script, and an expected results file available. Not sure though if it could be included in the standard regression tests on a configure-conditional basis -- anyone kn

Re: [PATCHES] [PATCH] s_lock support for win32

2004-07-01 Thread Claudio Natoli
Tom Lane writes: > Claudio Natoli <[EMAIL PROTECTED]> writes: > >> The win32 port doesn't have a native user space spinlock > >> implementation yet. > > > It does when compiled with MingW. > > Are we intending to support any other compilers/build environments > than that one? Not currently; at

Re: [PATCHES] contrib/dbmirror

2004-07-01 Thread Joe Conway
[EMAIL PROTECTED] wrote: Attached is a 1 line bug fix for dbmirror that was submitted. It fixes a bug where some transactions could be dropped when writing mirrored SQL statements to files. Patch applied. Joe ---(end of broadcast)--- TIP 1: subscrib

Re: [PATCHES] pg_tablespace_databases

2004-07-01 Thread Joe Conway
Andreas Pflug wrote: From an idea of Bruce, the attached patch implements the function pg_tablespace_databases(oid) RETURNS SETOF oid which delivers as set of database oids having objects in the selected tablespace, enabling an admin to examine only the databases affecting the tablespace for obje

Re: [PATCHES] pg_autovacuum integration attempt #2

2004-07-01 Thread Matthew T. O'Connor
FYI, I am out of town from Friday 7/2 till Monday evening 7/5. I probably won't have email while I'm gone. I will continue working on this when I get back. Also, I have made a few minor tweaks since submitting this patch namely changing autovac_enabled to default to false. I am also trying to u