Re: [PATCHES] Allow the identifier length to be increased via a

2006-12-28 Thread Dhanaraj M
Tom Lane wrote: Alvaro Herrera <[EMAIL PROTECTED]> writes: Dhanaraj M wrote: I am sending the patch for the following TODO item: Allow the identifier length to be increased via a configure option You should use pg_config.h, not mangle postgres_ext.h like that. Or maybe gen

Re: [PATCHES] pg_standby

2006-12-28 Thread Simon Riggs
On Thu, 2006-12-14 at 12:04 +, Simon Riggs wrote: > pg_standby and test framework, in separate .tar files New version (v2), following further testing. Signal handling not included in this version. -- Simon Riggs EnterpriseDB http://www.enterprisedb.com pg_standby.v2.ta

Re: [PATCHES] Dead Space Map patch

2006-12-28 Thread Simon Riggs
On Thu, 2006-12-28 at 15:14 +0900, ITAGAKI Takahiro wrote: > Even if it is off, DSM are always recorded and updated. The purpose of the patch, as I understand it, is performance. Can I ask what the performance overhead of this is for standard OLTP workloads? Do you have some performance numbers

Re: [PATCHES] [BUGS] BUG #2846: inconsistent and confusing

2006-12-28 Thread Bruce Momjian
Tom Lane wrote: > No, because you are still comparing against FLOAT4_MAX. I'm suggesting > that only an actual infinity should be rejected. Even that is contrary > to IEEE spec, though. > > The other problem with this coding technique is that it must invoke > isinf three times when the typical c

Re: [PATCHES] xlog directory at initdb time

2006-12-28 Thread Euler Taveira de Oliveira
Simon Riggs wrote: > > This simple patch lets someone specifies the xlog directory at initdb > > time. It uses symlinks to do it, and create and/or set permissions at > > the directory as appropriate. > > Looks good. > > I'm no expert on coding style, so I won't comment on anything there. > > A

Re: [PATCHES] pg_standby

2006-12-28 Thread Simon Riggs
On Thu, 2006-12-28 at 19:26 +, Simon Riggs wrote: > On Thu, 2006-12-14 at 12:04 +, Simon Riggs wrote: > > pg_standby and test framework, in separate .tar files > > New version (v2), following further testing. > > Signal handling not included in this version. Signal handling now added, te

Re: [PATCHES] Tablespace for temporary objects and sort files

2006-12-28 Thread Jaime Casanova
On 12/27/06, Albert Cervera Areny <[EMAIL PROTECTED]> wrote: Hi, here's a new version of the patch against HEAD with both, table and sort files working correctly for me. Regression tests work too. ok, i will test it a little ... what about temp tables created by SELECT INTO TEMP? look at

Re: [PATCHES] [BUGS] BUG #2846: inconsistent and confusing

2006-12-28 Thread Tom Lane
Bruce Momjian <[EMAIL PROTECTED]> writes: > I wasn't excited about doing one isinf() call to avoid three, so I just > made a fast isinf() macro: > /*We call isinf() a lot, so we use a fast version in this file */ > #define fast_isinf(val) (((val) < DBL_MIN || (val) > DBL_MAX) && > i

Re: [HACKERS] [PATCHES] [BUGS] BUG #2846: inconsistent and

2006-12-28 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian <[EMAIL PROTECTED]> writes: > > I wasn't excited about doing one isinf() call to avoid three, so I just > > made a fast isinf() macro: > > > /*We call isinf() a lot, so we use a fast version in this file */ > > #define fast_isinf(val) (((val) < DBL_MIN