Re: [Pharo-dev] Call for fixing the selection in the debugger

2013-12-27 Thread Nicolai Hess
On problem with the current solution (from 12144) is that TextModels readSelectionHolder is not updated when setSelection: is called. So, if you read the selection from the PluggableTextMorph it has always the same value (from its initialization) and not the actual selection (if you use the mouse t

Re: [Pharo-dev] Call for fixing the selection in the debugger

2013-12-27 Thread Andrei Chis
PluggableTextMorph maintains its own selectionInterval. When the PluggableTextMorph >>selectionInterval: it is called it sets the selection in the model. This will trigger MorphicTextAdapter>>setSelectionFromModel: that should adapt the selection in the morph: MorphicTextAdapter >>setSelectionFrom

Re: [Pharo-dev] Call for fixing the selection in the debugger

2013-12-27 Thread Tudor Girba
Hi, I reported the problem already: https://pharo.fogbugz.com/f/cases/12479/SpecDebugger-cannot-inspect-from-the-code-pane I just tried the GTDebugger in the latest Pharo and it works just fine. If the problem would be in the PluggableTextMorph, it should affect the GTDebugger, too since it is us

Re: [Pharo-dev] Call for fixing the selection in the debugger

2013-12-27 Thread Stéphane Ducasse
**thanks** guys for looking into that because this is blocking. Stef > I think that when the model is notified, it will set it in the morph > So it will happen twice > > Ben > > On 27 Dec 2013, at 15:52, Andrei Chis wrote: > >> Wouldn't then explicitly setting the selection of the morph befo

Re: [Pharo-dev] Call for fixing the selection in the debugger

2013-12-27 Thread Benjamin
I think that when the model is notified, it will set it in the morph So it will happen twice Ben On 27 Dec 2013, at 15:52, Andrei Chis wrote: > Wouldn't then explicitly setting the selection of the morph before setting it > in the model be ok? > > PluggableTextMorph>>selectionInterval: sel >

Re: [Pharo-dev] Call for fixing the selection in the debugger

2013-12-27 Thread Andrei Chis
Wouldn't then explicitly setting the selection of the morph before setting it in the model be ok? PluggableTextMorph>>selectionInterval: sel selectionInterval := sel. setSelectionSelector ifNotNil: [ self model perform:setSelectionSelector with: sel ] On Fri, Dec 27, 2013 at 4:28 PM, Be

Re: [Pharo-dev] Call for fixing the selection in the debugger

2013-12-27 Thread Benjamin
ok :( Then I run out of brilliant idea :P Ben On 27 Dec 2013, at 15:25, Andrei Chis wrote: > Adding 'self changed' at the end of the current > PluggableTextMorph>>selectionInterval: doesn't solve the problem. > > > On Fri, Dec 27, 2013 at 4:15 PM, Benjamin > wrote: > Because when the focus

Re: [Pharo-dev] Call for fixing the selection in the debugger

2013-12-27 Thread Andrei Chis
Adding 'self changed' at the end of the current PluggableTextMorph>>selectionInterval: doesn't solve the problem. On Fri, Dec 27, 2013 at 4:15 PM, Benjamin < benjamin.vanryseghem.ph...@gmail.com> wrote: > Because when the focus changes, the morph is proposed to redraw itself > Try with a > >

Re: [Pharo-dev] Call for fixing the selection in the debugger

2013-12-27 Thread Benjamin
Because when the focus changes, the morph is proposed to redraw itself Try with a self changed at the end Ben On 27 Dec 2013, at 14:44, Andrei Chis wrote: > > The change that seems to have caused this problem is in > PluggableTextMorph>>selectionInterval: The selectionInterval instance

Re: [Pharo-dev] Call for fixing the selection in the debugger

2013-12-27 Thread Andrei Chis
The change that seems to have caused this problem is in PluggableTextMorph>>selectionInterval: The selectionInterval instance variable of the morph is not set any more; only the model is updated, which doesn't seem to update the morph. PluggableTextMorph>>selectionInterval: sel setSelectionSelecto

Re: [Pharo-dev] Call for fixing the selection in the debugger

2013-12-27 Thread Marcus Denker
On 27 Dec 2013, at 14:11, Marcus Denker wrote: > > On 27 Dec 2013, at 13:01, Stéphane Ducasse wrote: > >> Hi guys >> >> we should not let the system in such state. We cannot inspect print >> expression in the debugger. >> Does anybody have an idea of the change that broke it? >> > Yes: >

Re: [Pharo-dev] Call for fixing the selection in the debugger

2013-12-27 Thread Marcus Denker
On 27 Dec 2013, at 13:01, Stéphane Ducasse wrote: > Hi guys > > we should not let the system in such state. We cannot inspect print > expression in the debugger. > Does anybody have an idea of the change that broke it? > Yes: https://pharo.fogbugz.com/f/cases/12144/TextModel-getSelec

Re: [Pharo-dev] Call for fixing the selection in the debugger

2013-12-27 Thread Stéphane Ducasse
this is also happening in the implementors pane. in fact it is impossible to select a new selection. > Hi guys > > we should not let the system in such state. We cannot inspect print > expression in the debugger. > Does anybody have an idea of the change that broke it? > > Stef

[Pharo-dev] Call for fixing the selection in the debugger

2013-12-27 Thread Stéphane Ducasse
Hi guys we should not let the system in such state. We cannot inspect print expression in the debugger. Does anybody have an idea of the change that broke it? Stef