[Pharo-dev] Call for test: Dark Theme now ready (?) for integration

2014-05-15 Thread Esteban Lorenzano
Hi, So I made a pass on the dark theme and I ensured it does not contains hacks and still works. And you can switch between themes without braking anything (but you need to restart all windows). How it works now? - I removed tons and tons of hardcoded colors all around image - I redirected d

Re: [Pharo-dev] Call for test: Dark Theme now ready (?) for integration

2014-05-15 Thread Esteban A. Maringolo
So I load as I loaded the previous on Pharo 3, but this time no merge will be required? Regards! Esteban A. Maringolo 2014-05-15 13:07 GMT-03:00 Esteban Lorenzano : > Hi, > > So I made a pass on the dark theme and I ensured it does not contains hacks > and still works. And you can switch betwee

Re: [Pharo-dev] Call for test: Dark Theme now ready (?) for integration

2014-05-15 Thread kilon alios
is the installation procedure exactly the same ? Do we still need to merge ? this is what I use for installation “1. You need this because otherwise Gofer merge becomes dumb :P" MCRepositoryGroup default addRepository: (MCSmalltalkhubRepository owner: 'estebanlm' project: 'Pha

Re: [Pharo-dev] Call for test: Dark Theme now ready (?) for integration

2014-05-15 Thread Esteban Lorenzano
no, no… is the same. You still need to merge :) But if we have a “good to go” the idea is to integrate it. Esteban On 15 May 2014, at 18:15, kilon alios wrote: > is the installation procedure exactly the same ? Do we still need to merge ? > > this is what I use for installation > > “1. You

Re: [Pharo-dev] Call for test: Dark Theme now ready (?) for integration

2014-05-15 Thread p...@highoctane.be
Did you fix the DiffMorph colors? The colorForType: thing. Le 15 mai 2014 18:20, "Esteban Lorenzano" a écrit : > no, no… is the same. You still need to merge :) > But if we have a “good to go” the idea is to integrate it. > > Esteban > > On 15 May 2014, at 18:15, kilon alios wrote: > > is the

Re: [Pharo-dev] Call for test: Dark Theme now ready (?) for integration

2014-05-15 Thread Esteban Lorenzano
On 15 May 2014, at 18:24, p...@highoctane.be wrote: > Did you fix the DiffMorph colors? > > a bit… I think there is still a need to work there, but now at least you can see the changes :) Esteban > > The colorForType: thing. > Le 15 mai 2014 18:20, "Esteban Lorenzano" a écrit : > no, no… is

Re: [Pharo-dev] Call for test: Dark Theme now ready (?) for integration

2014-05-15 Thread Clara Allende
2014-05-15 18:13 GMT+02:00 Esteban A. Maringolo : > So I load as I loaded the previous on Pharo 3, but this time no merge > will be required? > This time there weren't merge conflicts, if that's what you mean for "no merge required" Esteban, is that part of the fix? (Thanks if it is :D ) > > Re