Re: [Pharo-dev] Cleanup of debug requests API

2015-11-25 Thread Denis Kudriashov
2015-11-25 17:16 GMT+01:00 Andrei Chis : > Hi, > > In updating the debuggers from moose to the new API just one small issue > came up: > > - Process>>newDebugSessionNamed:startedAt: hardcodes DebugSession. However > we are using different debugging sessions. > > The

Re: [Pharo-dev] Cleanup of debug requests API

2015-11-25 Thread Andrei Chis
On Wed, Nov 25, 2015 at 6:29 PM, Denis Kudriashov wrote: > > 2015-11-25 17:16 GMT+01:00 Andrei Chis : > >> Hi, >> >> In updating the debuggers from moose to the new API just one small issue >> came up: >> >> -

Re: [Pharo-dev] Cleanup of debug requests API

2015-11-23 Thread Denis Kudriashov
Fixed slice in inbox 2015-11-21 13:07 GMT+01:00 Denis Kudriashov : > > 2015-11-21 10:55 GMT+01:00 Nicolai Hess : > >> The SyntaxErrorDebugger registers itself for Smalltalk tools: >> >> registerToolsOn: registry >> "Add ourselves to registry. See

Re: [Pharo-dev] Cleanup of debug requests API

2015-11-23 Thread stepharo
Le 21/11/15 15:32, Ben Coman a écrit : An auxiliary concern here this /nice/correct/ form of using self makes it invisible to the usual "users-of" search tools. I've been bitten by similar before. What can we do to make this use case more visible? If I remember correctly the completion

Re: [Pharo-dev] Cleanup of debug requests API

2015-11-21 Thread Ben Coman
An auxiliary concern here this /nice/correct/ form of using self makes it invisible to the usual "users-of" search tools. I've been bitten by similar before. What can we do to make this use case more visible? A pragmatic option might be to de-tune the purity of form and use... registry

Re: [Pharo-dev] Cleanup of debug requests API

2015-11-21 Thread Denis Kudriashov
Ok. I just read Nicolai comment. So question: is SyntaxErrorDebugger used anywhere? I remove it because it uses another way how to open debugger 21 нояб. 2015 г. 10:15 AM пользователь "Max Leske" написал: > > On 21 Nov 2015, at 09:34, Denis Kudriashov

Re: [Pharo-dev] Cleanup of debug requests API

2015-11-21 Thread Max Leske
> On 21 Nov 2015, at 10:22, Denis Kudriashov wrote: > > Ok. > I just read Nicolai comment. > So question: is SyntaxErrorDebugger used anywhere? I remove it because it > uses another way how to open debugger > > My quick check didn’t turn up anything. But to be sure,

Re: [Pharo-dev] Cleanup of debug requests API

2015-11-21 Thread Denis Kudriashov
Slice was declined because I remove SyntaxErrorDebugger. I not found any reference to it. And there was no instances of it. Can anybody show me where it is used? 20 нояб. 2015 г. 19:27 пользователь "Andrei Chis" < chisvasileand...@gmail.com> написал: > Very nice. I remember when I made GTDebugger

Re: [Pharo-dev] Cleanup of debug requests API

2015-11-21 Thread Max Leske
Oops! Thanks Nicolai. I missed that. > On 21 Nov 2015, at 10:59, Nicolai Hess wrote: > > Or if you type in a syntactically incorrect expression in inspectors search > field: > > > > 2015-11-21 10:55 GMT+01:00 Nicolai Hess

Re: [Pharo-dev] Cleanup of debug requests API

2015-11-21 Thread Nicolai Hess
2015-11-21 10:43 GMT+01:00 Max Leske : > > On 21 Nov 2015, at 10:22, Denis Kudriashov wrote: > > Ok. > I just read Nicolai comment. > So question: is SyntaxErrorDebugger used anywhere? I remove it because it > uses another way how to open debugger > > >

Re: [Pharo-dev] Cleanup of debug requests API

2015-11-21 Thread Denis Kudriashov
2015-11-21 10:55 GMT+01:00 Nicolai Hess : > The SyntaxErrorDebugger registers itself for Smalltalk tools: > > registerToolsOn: registry > "Add ourselves to registry. See [Smalltalk tools]" > registry register: self as: #syntaxErrorDebugger > > And this is used by

Re: [Pharo-dev] Cleanup of debug requests API

2015-11-21 Thread Nicolai Hess
Or if you type in a syntactically incorrect expression in inspectors search field: 2015-11-21 10:55 GMT+01:00 Nicolai Hess : > > > 2015-11-21 10:43 GMT+01:00 Max Leske : > >> >> On 21 Nov 2015, at 10:22, Denis Kudriashov wrote:

Re: [Pharo-dev] Cleanup of debug requests API

2015-11-21 Thread Max Leske
> On 21 Nov 2015, at 09:34, Denis Kudriashov wrote: > > Slice was declined because I remove SyntaxErrorDebugger. I not found any > reference to it. And there was no instances of it. Can anybody show me where > it is used? > > Are you sure? The validation says that it

[Pharo-dev] Cleanup of debug requests API

2015-11-20 Thread Denis Kudriashov
Hi I try to investigate how debugger opens and who initiates it. I want to cleanup this logic and simplify current debugger API. I found that basic error debugging starts with UIManager then UIManager calls SpecDebugger, then SpecDebugger calls UIManager and again... At the end of this chain

Re: [Pharo-dev] Cleanup of debug requests API

2015-11-20 Thread Andrei Chis
Very nice. I remember when I made GTDebugger that there were way to many ways to open the debugger. I ended up just copy-pasting things. Would be very useful to have a small doc with what one needs to do to replace SpecDebugger with another debugger (e.g. what are the entry points of the debugger

Re: [Pharo-dev] Cleanup of debug requests API

2015-11-20 Thread Denis Kudriashov
I clean and refactor all but lowSpaceWatcher. It is in slice 17069. In my image it is not broke stuff. So I hope it is safe change. 2015-11-20 12:18 GMT+01:00 Denis Kudriashov : > Hi > > I try to investigate how debugger opens and who initiates it. > I want to cleanup this