Re: [Pharo-dev] Critics Browser should diff formatted original

You are welcome. There are more things to take into account. There is prettyprinted diff class, that should do it automatically, but it does not work because what you are getting after applying transformation - is regenerated source code i.e. there can be extra parentheses and so on. Also the d

Re: [Pharo-dev] Critics Browser should diff formatted original

Sean P. DeNigris wrote > Issue 15574: Critics: Ignore whitespace changes when diffing > transformations > https://pharo.fogbugz.com/default.asp?15574 Thanks to Yuriy, now the confusing diff on the left will look like the one on the right

Re: [Pharo-dev] Critics Browser should diff formatted original

Sean P. DeNigris wrote > How about we diff the original source /re-formatted/ against the > transformed source? Issue 15574: Critics: Ignore whitespace changes when diffing transformations https://pharo.fogbugz.com/default.asp?15574 - Cheers, Sean -- View this message in context: http://fo

Re: [Pharo-dev] Critics Browser should diff formatted original

I agree. ​

[Pharo-dev] Critics Browser should diff formatted original

It's difficult to see what the actual changes are when the formatter makes significant whitespace changes. How about we diff the original source /re-formatted/ against the transformed source? - Cheers, Sean -- View this message in context: http://forum.world.st/Critics-Browser-should-diff-f